From e95d73958d64cbc514f3fee7dcc12a572eb82300 Mon Sep 17 00:00:00 2001 From: Martin Storsjo Date: Thu, 16 Nov 2017 19:36:48 +0000 Subject: [PATCH] Remove a FIXME about truncated section names If the linker chose to store the full section name instead of truncating it, this field doesn't contain a truncated name, but an offset into the string table of the binary. The string table isn't loaded/mapped into memory during runtime though, so it's not possible to read the full section name, unless we try to locate the DLL/EXE on disk that the HMODULE corresponds to and load that manually. Due to this, lld now always prefers writing a truncated section name for sections that will be mapped at runtime, even when debug info is enabled. Differential Revision: https://reviews.llvm.org/D39918 llvm-svn: 318446 --- libunwind/src/AddressSpace.hpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/libunwind/src/AddressSpace.hpp b/libunwind/src/AddressSpace.hpp index 3242840..2be16af 100644 --- a/libunwind/src/AddressSpace.hpp +++ b/libunwind/src/AddressSpace.hpp @@ -382,8 +382,6 @@ inline bool LocalAddressSpace::findUnwindSections(pint_t targetAddr, found_obj = true; } else if (!strncmp((const char *)pish->Name, ".eh_frame", IMAGE_SIZEOF_SHORT_NAME)) { - // FIXME: This section name actually is truncated, ideally we - // should locate and check the full long name instead. info.dwarf_section = begin; info.dwarf_section_length = pish->Misc.VirtualSize; found_hdr = true; -- 2.7.4