From e913b9cb939c45ce9cbf0f224da6466cd3094c3a Mon Sep 17 00:00:00 2001 From: Luis Machado Date: Fri, 14 Oct 2016 09:04:46 -0500 Subject: [PATCH] Fix leftover remote test failures from PR binutils/19020 As pointed out in PR binutils/19020, those tests were still failing when doing remote testing. This is because the binary files weren't being copied over to the remote host for testing. FAIL: binutils-all/pr19020a FAIL: binutils-all/pr19020b This small patch fixes this up to make things pass. binutils/ChangeLog: 2016-10-14 Luis Machado * testsuite/lib/utils-lib.exp (run_dump_test): Call remote_download to copy file to remote host. --- binutils/ChangeLog | 5 +++++ binutils/testsuite/lib/utils-lib.exp | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index a4cbad6..6bd65d7 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2016-10-14 Luis Machado + + * testsuite/lib/utils-lib.exp (run_dump_test): Call remote_download + to copy file to remote host. + 2016-10-11 Nick Clifton * objdump.c (is_significant_symbol_name): New function. diff --git a/binutils/testsuite/lib/utils-lib.exp b/binutils/testsuite/lib/utils-lib.exp index 6d2de5d..b93da51 100644 --- a/binutils/testsuite/lib/utils-lib.exp +++ b/binutils/testsuite/lib/utils-lib.exp @@ -464,7 +464,8 @@ proc run_dump_test { name {extra_options {}} } { } set srcfile $newfile } - file copy -force ${srcfile} $tempfile + # Make sure we copy the file if we are doing remote host testing. + remote_download host ${srcfile} $tempfile } else { set exec_output [binutils_assemble_flags ${srcfile} $tempfile $opts(as)] if [string match "" $exec_output] then { -- 2.7.4