From e8d1578131247d089209952476ba9191ad0295be Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 21 Nov 2019 09:06:14 -0600 Subject: [PATCH] [Hexagon] Remove incorrect intrinsic definition and invalid testcase The intrinsic int_hexagon_S2_asr_i_vh was mapped to S2_asr_r_vh, which is wrong. The testcase vasrh.select.ll was using an invalid immediate for that intrinsic. This is not a proper testcase, since at the MIR level such use of this intrinsic should never appear. Together with 824b25fc02, this completes the fix for llvm.org/PR44090. --- llvm/lib/Target/Hexagon/HexagonIntrinsics.td | 3 --- llvm/test/CodeGen/Hexagon/vasrh.select.ll | 33 ---------------------------- 2 files changed, 36 deletions(-) delete mode 100644 llvm/test/CodeGen/Hexagon/vasrh.select.ll diff --git a/llvm/lib/Target/Hexagon/HexagonIntrinsics.td b/llvm/lib/Target/Hexagon/HexagonIntrinsics.td index c5e3cfd..8ae55b2 100644 --- a/llvm/lib/Target/Hexagon/HexagonIntrinsics.td +++ b/llvm/lib/Target/Hexagon/HexagonIntrinsics.td @@ -353,9 +353,6 @@ def: Pat<(v64i16 (trunc v64i32:$Vdd)), (v32i32 (V6_lo HvxWR:$Vdd))))>, Requires<[UseHVX]>; -def: Pat<(int_hexagon_S2_asr_i_vh DoubleRegs:$src1, IntRegs:$src2), - (S2_asr_r_vh DoubleRegs:$src1, IntRegs:$src2)>, Requires<[HasV55]>; - multiclass T_VI_pat { def: Pat<(IntID HvxVR:$src1, u3_0ImmPred:$src2), (MI HvxVR:$src1, HvxVR:$src1, u3_0ImmPred:$src2)>, diff --git a/llvm/test/CodeGen/Hexagon/vasrh.select.ll b/llvm/test/CodeGen/Hexagon/vasrh.select.ll deleted file mode 100644 index d6fc3af..0000000 --- a/llvm/test/CodeGen/Hexagon/vasrh.select.ll +++ /dev/null @@ -1,33 +0,0 @@ -; RUN: llc -march=hexagon -O0 < %s | FileCheck %s - -; We do not want to see a 'cannot select' error, -; we would like to see a vasrh instruction -; CHECK: vasrh - -target triple = "hexagon" - -@g0 = global [6 x i64] [i64 0, i64 1, i64 10000, i64 -9223372036854775808, i64 9223372036854775807, i64 -1], align 8 -@g1 = common global i32 0, align 4 - -; Function Attrs: nounwind -define i32 @f0() #0 { -b0: - %v0 = load i64, i64* getelementptr inbounds ([6 x i64], [6 x i64]* @g0, i32 0, i32 0), align 8, !tbaa !0 - %v1 = tail call i64 @llvm.hexagon.S2.asr.i.vh(i64 %v0, i32 62) - %v2 = trunc i64 %v1 to i32 - store i32 %v2, i32* @g1, align 4, !tbaa !4 - ret i32 0 -} - -; Function Attrs: nounwind readnone -declare i64 @llvm.hexagon.S2.asr.i.vh(i64, i32) #1 - -attributes #0 = { nounwind "target-cpu"="hexagonv55" } -attributes #1 = { nounwind readnone } - -!0 = !{!1, !1, i64 0} -!1 = !{!"long long", !2, i64 0} -!2 = !{!"omnipotent char", !3, i64 0} -!3 = !{!"Simple C/C++ TBAA"} -!4 = !{!5, !5, i64 0} -!5 = !{!"int", !2, i64 0} -- 2.7.4