From e8a4ca70ce34eac224eb0e3f43a6136fc72016f0 Mon Sep 17 00:00:00 2001 From: "tony@chromium.org" Date: Sat, 30 Jun 2012 02:36:41 +0000 Subject: [PATCH] Allow align-self: stretch to cause the item size to shrink below its intrinsic size https://bugs.webkit.org/show_bug.cgi?id=90304 Reviewed by Ojan Vafai. Source/WebCore: The spec used to say that stretch could only make items grow, but now it allows items to shrink. http://dev.w3.org/csswg/css3-flexbox/#align-items-stretch Tests: css3/flexbox/flex-align-stretch.html Updated expectations. css3/flexbox/child-overflow.html Updated expectations. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): LayoutTests: * css3/flexbox/child-overflow-expected.html: * css3/flexbox/child-overflow.html: * css3/flexbox/flex-align-stretch.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121611 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 11 +++++++++++ LayoutTests/css3/flexbox/child-overflow-expected.html | 19 +++++++++---------- LayoutTests/css3/flexbox/child-overflow.html | 3 +-- LayoutTests/css3/flexbox/flex-align-stretch.html | 4 +--- Source/WebCore/ChangeLog | 17 +++++++++++++++++ Source/WebCore/rendering/RenderFlexibleBox.cpp | 2 -- 6 files changed, 39 insertions(+), 17 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 58f781d..af7edd7 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,14 @@ +2012-06-29 Tony Chang + + Allow align-self: stretch to cause the item size to shrink below its intrinsic size + https://bugs.webkit.org/show_bug.cgi?id=90304 + + Reviewed by Ojan Vafai. + + * css3/flexbox/child-overflow-expected.html: + * css3/flexbox/child-overflow.html: + * css3/flexbox/flex-align-stretch.html: + 2012-06-29 James Weatherall NPObjectWrapper may not address all window script object lifetime issues diff --git a/LayoutTests/css3/flexbox/child-overflow-expected.html b/LayoutTests/css3/flexbox/child-overflow-expected.html index b688e66..2581602 100644 --- a/LayoutTests/css3/flexbox/child-overflow-expected.html +++ b/LayoutTests/css3/flexbox/child-overflow-expected.html @@ -29,28 +29,27 @@ p { -

Scrollbars should work in all the flexboxes. The first and third - columns should overflow the logical height. Each row should be aligned +

Scrollbars should work in all the flexboxes. Each row should be aligned to the same corner.