From e885d762c09c24797c89bb76055bf130a686be54 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Kristian=20H=C3=B8gsberg=20Kristensen?= Date: Mon, 1 Feb 2016 15:14:25 -0800 Subject: [PATCH] Don't use uninitialized variables in dEQP-VK.api.copy_and_blit.buffer_to_image The buffer to image test was using the uninitialized src image extent for initializing the src buffer and the uninitialized dst buffer size for initializing the dst image. --- .../vulkancts/modules/vulkan/api/vktApiCopiesAndBlittingTests.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/external/vulkancts/modules/vulkan/api/vktApiCopiesAndBlittingTests.cpp b/external/vulkancts/modules/vulkan/api/vktApiCopiesAndBlittingTests.cpp index 1a1fcac..6cf5f46 100644 --- a/external/vulkancts/modules/vulkan/api/vktApiCopiesAndBlittingTests.cpp +++ b/external/vulkancts/modules/vulkan/api/vktApiCopiesAndBlittingTests.cpp @@ -1313,12 +1313,13 @@ CopyBufferToImage::CopyBufferToImage (Context& context, TestParams testParams) tcu::TestStatus CopyBufferToImage::iterate() { m_sourceTextureLevel = de::MovePtr(new tcu::TextureLevel(m_textureFormat, (int)m_params.src.buffer.size, 1)); - generateBuffer(m_sourceTextureLevel->getAccess(), m_params.src.image.extent.width, m_params.src.image.extent.height, m_params.src.image.extent.depth, FILL_MODE_WHITE); + generateBuffer(m_sourceTextureLevel->getAccess(), (int)m_params.src.buffer.size, 1, 1); m_destinationTextureLevel = de::MovePtr(new tcu::TextureLevel(m_textureFormat, m_params.dst.image.extent.width, m_params.dst.image.extent.height, m_params.dst.image.extent.depth)); - generateBuffer(m_destinationTextureLevel->getAccess(), (int)m_params.dst.buffer.size, 1, 1, FILL_MODE_SEQUENTIAL); + + generateBuffer(m_destinationTextureLevel->getAccess(), m_params.dst.image.extent.width, m_params.dst.image.extent.height, m_params.dst.image.extent.depth, FILL_MODE_WHITE); generateExpectedResult(); -- 2.7.4