From e7f4c4bf99ad5edca35ccc18105daf5279b54919 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 14 Jun 2017 12:12:09 +0300 Subject: [PATCH] pinctrl: ingenic: checking for NULL instead of IS_ERR() devm_pinctrl_register() returns error pointers, it doesn't return NULL. Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs") Signed-off-by: Dan Carpenter Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-ingenic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index d8473d9..d8e8842 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev) } jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc); - if (!jzpc->pctl) { + if (IS_ERR(jzpc->pctl)) { dev_err(dev, "Failed to register pinctrl\n"); - return -EINVAL; + return PTR_ERR(jzpc->pctl); } for (i = 0; i < chip_info->num_groups; i++) { -- 2.7.4