From e7da3a104cc95891ca76e7c58dfbfdcba8659996 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 20 Apr 2012 14:06:53 +0200 Subject: [PATCH] Disable the tst_exceptionsafety_others test completely. QObject is no longer exception-safe and there's no one working on improving this, so let's not block innocent commits because of this failure. QObjectPrivate's constructor initialises the QObjectPrivate::threadData member to null, but the destructor dereferences it unconditionally (the member is initialised in the QObject constructor). That means QObjectPrivate is not exception-safe by any definition and, so, anything depending on QObject is not exception-safe. Change-Id: If9d5004630b7ce2fb357e328627794caad67564f Reviewed-by: Jason McDonald --- tests/auto/other/other.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/other/other.pro b/tests/auto/other/other.pro index 2a6dc1d..b6154a8 100644 --- a/tests/auto/other/other.pro +++ b/tests/auto/other/other.pro @@ -5,7 +5,7 @@ SUBDIRS=\ collections \ compiler \ exceptionsafety \ - exceptionsafety_objects \ + # exceptionsafety_objects \ # QObjectPrivate is not safe gestures \ headersclean \ lancelot \ -- 2.7.4