From e7c63fc51c77e4b90c7d389b4f2f4142683e6fed Mon Sep 17 00:00:00 2001 From: Nanley Chery Date: Thu, 18 May 2023 11:10:03 -0700 Subject: [PATCH] iris: Assert against FCV_CCS_E for blitter writes The FCV feature is documented to occur on regular render writes. Blitter writes don't fall under that category. So, if the destination resource of a blitter write had the FCV aux usage, we would have a good reason to change the aux usage of the access to plain CCS_E. We don't actually need to write code to handle this. iris doesn't use any compression on blitter writes. Make that obvious with an assert. Reviewed-by: Rohan Garg Part-of: --- src/gallium/drivers/iris/iris_blit.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/iris/iris_blit.c b/src/gallium/drivers/iris/iris_blit.c index af9ed36..82d466a 100644 --- a/src/gallium/drivers/iris/iris_blit.c +++ b/src/gallium/drivers/iris/iris_blit.c @@ -630,6 +630,10 @@ get_copy_region_aux_settings(struct iris_context *ice, bool is_zero = clear_color_is_fully_zero(res); if (batch->name == IRIS_BATCH_BLITTER) { + + /* Compression isn't used for blitter destinations. */ + assert(!is_dest); + if (devinfo->verx10 >= 125) { *out_aux_usage = res->aux.usage; *out_clear_supported = is_zero; -- 2.7.4