From e7ade78a8ceb6da9f2a9bd9f804942ad11549d6e Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Fri, 10 Feb 2023 16:48:34 -0800 Subject: [PATCH] [dfsan] Fix some build-libc-list.py lint issues --- compiler-rt/lib/dfsan/scripts/build-libc-list.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/compiler-rt/lib/dfsan/scripts/build-libc-list.py b/compiler-rt/lib/dfsan/scripts/build-libc-list.py index a90649d..aa155b2 100755 --- a/compiler-rt/lib/dfsan/scripts/build-libc-list.py +++ b/compiler-rt/lib/dfsan/scripts/build-libc-list.py @@ -40,9 +40,11 @@ import subprocess import sys from optparse import OptionParser -def defined_function_list(object): + +def defined_function_list(lib): + """Get non-local function symbols from lib.""" functions = [] - readelf_proc = subprocess.Popen(['readelf', '-s', '-W', object], + readelf_proc = subprocess.Popen(['readelf', '-s', '-W', lib], stdout=subprocess.PIPE) readelf = readelf_proc.communicate()[0].decode().split('\n') if readelf_proc.returncode != 0: @@ -85,8 +87,5 @@ if options.error_missing_lib and missing_lib: print('Exiting with failure code due to missing library.', file=sys.stderr) exit(1) -functions = list(set(functions)) -functions.sort() - -for f in functions: +for f in sorted(set(functions)): print('fun:%s=uninstrumented' % f) -- 2.7.4