From e76b5d442b583e3856e5325261d6fd0b516d3737 Mon Sep 17 00:00:00 2001 From: Armin Novak Date: Thu, 7 Feb 2019 17:42:11 +0100 Subject: [PATCH] Silenced unused parameter warnings, added log messages. --- server/shadow/X11/x11_shadow.c | 6 ++++++ server/shadow/shadow_audin.c | 2 ++ server/shadow/shadow_client.c | 1 + server/shadow/shadow_server.c | 6 ++++++ 4 files changed, 15 insertions(+) diff --git a/server/shadow/X11/x11_shadow.c b/server/shadow/X11/x11_shadow.c index 22c043a..d91392d 100644 --- a/server/shadow/X11/x11_shadow.c +++ b/server/shadow/X11/x11_shadow.c @@ -168,6 +168,8 @@ static int x11_shadow_pam_authenticate(rdpShadowSubsystem* subsystem, { int pam_status; SHADOW_PAM_AUTH_INFO* info; + WINPR_UNUSED(subsystem); + WINPR_UNUSED(client); info = calloc(1, sizeof(SHADOW_PAM_AUTH_INFO)); if (!info) @@ -222,6 +224,8 @@ static int x11_shadow_pam_authenticate(rdpShadowSubsystem* subsystem, static BOOL x11_shadow_input_synchronize_event(rdpShadowSubsystem* subsystem, rdpShadowClient* client, UINT32 flags) { + /* TODO: Implement */ + WLog_WARN(TAG, "%s not implemented", __FUNCTION__); return TRUE; } @@ -273,6 +277,8 @@ static BOOL x11_shadow_input_unicode_keyboard_event(rdpShadowSubsystem* subsystem, rdpShadowClient* client, UINT16 flags, UINT16 code) { + /* TODO: Implement */ + WLog_WARN(TAG, "%s not implemented", __FUNCTION__); return TRUE; } diff --git a/server/shadow/shadow_audin.c b/server/shadow/shadow_audin.c index 469debe..abaf199 100644 --- a/server/shadow/shadow_audin.c +++ b/server/shadow/shadow_audin.c @@ -69,6 +69,8 @@ static UINT AudinServerOpening(audin_server_context* context) */ static UINT AudinServerOpenResult(audin_server_context* context, UINT32 result) { + /* TODO: Implement */ + WLog_WARN(TAG, "%s not implemented", __FUNCTION__); WLog_INFO(TAG, "AUDIN open result %"PRIu32".\n", result); return CHANNEL_RC_OK; } diff --git a/server/shadow/shadow_client.c b/server/shadow/shadow_client.c index 22e39e2..6d46d38 100644 --- a/server/shadow/shadow_client.c +++ b/server/shadow/shadow_client.c @@ -1556,6 +1556,7 @@ static INLINE BOOL shadow_client_no_surface_update(rdpShadowClient* client, { rdpShadowServer* server; rdpShadowSurface* surface; + WINPR_UNUSED(pStatus); server = client->server; surface = client->inLobby ? server->lobby : server->surface; return shadow_client_surface_update(client, &(surface->invalidRegion)); diff --git a/server/shadow/shadow_server.c b/server/shadow/shadow_server.c index 3a493e9..e3f98a0 100644 --- a/server/shadow/shadow_server.c +++ b/server/shadow/shadow_server.c @@ -70,6 +70,10 @@ static int shadow_server_print_command_line_help(int argc, char** argv) char* str; int length; COMMAND_LINE_ARGUMENT_A* arg; + + if (argc < 1) + return -1; + WLog_INFO(TAG, "Usage: %s [options]", argv[0]); WLog_INFO(TAG, ""); WLog_INFO(TAG, "Syntax:"); @@ -134,6 +138,8 @@ static int shadow_server_print_command_line_help(int argc, char** argv) int shadow_server_command_line_status_print(rdpShadowServer* server, int argc, char** argv, int status) { + WINPR_UNUSED(server); + if (status == COMMAND_LINE_STATUS_PRINT_VERSION) { WLog_INFO(TAG, "FreeRDP version %s (git %s)", FREERDP_VERSION_FULL, GIT_REVISION); -- 2.7.4