From e75605822e3190a1bd7935599e93f13ab1ba7c9d Mon Sep 17 00:00:00 2001 From: Thomas Graf Date: Fri, 28 Nov 2014 14:34:31 +0100 Subject: [PATCH] rocker: Add proper validation of Netlink attributes Signed-off-by: Thomas Graf Signed-off-by: Jiri Pirko Signed-off-by: Scott Feldman Signed-off-by: David S. Miller --- drivers/net/ethernet/rocker/rocker.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c index 61cfdbf..30687bf 100644 --- a/drivers/net/ethernet/rocker/rocker.c +++ b/drivers/net/ethernet/rocker/rocker.c @@ -3712,6 +3712,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev, if (afspec) { attr = nla_find_nested(afspec, IFLA_BRIDGE_MODE); if (attr) { + if (nla_len(attr) < sizeof(mode)) + return -EINVAL; + mode = nla_get_u16(attr); if (mode != BRIDGE_MODE_SWDEV) return -EINVAL; @@ -3721,6 +3724,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev, if (protinfo) { attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING); if (attr) { + if (nla_len(attr) < sizeof(u8)) + return -EINVAL; + if (nla_get_u8(attr)) rocker_port->brport_flags |= BR_LEARNING; else @@ -3731,6 +3737,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev, } attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING_SYNC); if (attr) { + if (nla_len(attr) < sizeof(u8)) + return -EINVAL; + if (nla_get_u8(attr)) rocker_port->brport_flags |= BR_LEARNING_SYNC; else -- 2.7.4