From e6fb579f4131506c14195788c6a5ae980ca7b05d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 18 Oct 2011 14:20:36 +0200 Subject: [PATCH] maint: tac: prefer "failed to" diagnostic over "cannot" * src/tac.c: Change wording in diagnostic: "failed to open" seems clearer than "cannot open". --- src/tac.c | 8 +++++--- tests/misc/tac | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/tac.c b/src/tac.c index 7cc562e..01150a3 100644 --- a/src/tac.c +++ b/src/tac.c @@ -449,7 +449,7 @@ temp_stream (FILE **fp, char **file_name) int fd = mkstemp (tempfile); if (fd < 0) { - error (0, errno, _("cannot create temporary file in %s"), + error (0, errno, _("failed to create temporary file in %s"), quote (tempdir)); goto Reset; } @@ -457,7 +457,8 @@ temp_stream (FILE **fp, char **file_name) tmp_fp = fdopen (fd, (O_BINARY ? "w+b" : "w+")); if (! tmp_fp) { - error (0, errno, _("cannot open %s for writing"), quote (tempfile)); + error (0, errno, _("failed to open %s for writing"), + quote (tempfile)); close (fd); unlink (tempfile); Reset: @@ -569,7 +570,8 @@ tac_file (const char *filename) fd = open (filename, O_RDONLY | O_BINARY); if (fd < 0) { - error (0, errno, _("cannot open %s for reading"), quote (filename)); + error (0, errno, _("failed to open %s for reading"), + quote (filename)); return false; } } diff --git a/tests/misc/tac b/tests/misc/tac index 7bd07bd..5602128 100755 --- a/tests/misc/tac +++ b/tests/misc/tac @@ -68,7 +68,7 @@ my @Tests = {ENV => "TMPDIR=$bad_dir"}, {IN_PIPE => "a\n"}, {ERR_SUBST => "s,`$bad_dir': .*,...,"}, - {ERR => "$prog: cannot create temporary file in ...\n"}, + {ERR => "$prog: failed to create temporary file in ...\n"}, {EXIT => 1}], # coreutils-8.5's tac would double-free its primary buffer. -- 2.7.4