From e6db7c22530b659cb34e1eb9f983cf60b7ee8b4c Mon Sep 17 00:00:00 2001 From: Stefan Stanacar Date: Fri, 12 Jul 2013 13:38:53 +0300 Subject: [PATCH] lib/oeqa/oetest.py: provide a ps command for all tests Many tests will use 'ps' but we need to know if it's busybox or standard ps. Drop the existing check from the connman test. (From OE-Core rev: 1515d33d2c5b7275a3ac20e07c1db1d8273de796) Signed-off-by: Stefan Stanacar Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- meta/lib/oeqa/oetest.py | 5 ++--- meta/lib/oeqa/runtime/connman.py | 5 ----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/meta/lib/oeqa/oetest.py b/meta/lib/oeqa/oetest.py index 24548e9..5777ff8 100644 --- a/meta/lib/oeqa/oetest.py +++ b/meta/lib/oeqa/oetest.py @@ -9,7 +9,8 @@ def runTests(tc): # set the context object passed from the test class setattr(oeRuntimeTest, "tc", tc) - + # set ps command to use + setattr(oeRuntimeTest, "pscmd", "ps -ef" if oeRuntimeTest.hasPackage("procps") else "ps") # prepare test suite, loader and runner suite = unittest.TestSuite() testloader = unittest.TestLoader() @@ -30,7 +31,6 @@ class oeRuntimeTest(unittest.TestCase): testFailures = [] testSkipped = [] testErrors = [] - pscmd = "ps" def __init__(self, methodName='runTest'): self.target = oeRuntimeTest.tc.target @@ -74,7 +74,6 @@ class oeRuntimeTest(unittest.TestCase): - def getmodule(pos=2): # stack returns a list of tuples containg frame information # First element of the list the is current frame, caller is 1 diff --git a/meta/lib/oeqa/runtime/connman.py b/meta/lib/oeqa/runtime/connman.py index 835e135..5ef96f6 100644 --- a/meta/lib/oeqa/runtime/connman.py +++ b/meta/lib/oeqa/runtime/connman.py @@ -17,11 +17,6 @@ class ConnmanTest(oeRuntimeTest): @skipUnlessPassed('test_connmand_help') def test_connmand_running(self): - status = self.target.run('ls -l `which ps` | grep busybox')[0] - if status == 0: - oeRuntimeTest.pscmd = 'ps' - else: - oeRuntimeTest.pscmd = 'ps -ef' (status, output) = self.target.run(oeRuntimeTest.pscmd + ' | grep [c]onnmand') self.assertEqual(status, 0, msg="no connmand process, ps output: %s" % self.target.run(oeRuntimeTest.pscmd)[1]) -- 2.7.4