From e6d6f802a57b8fdca70b0ac5a7f67381d4fe51c0 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Thu, 8 Jul 2010 13:36:42 -0500 Subject: [PATCH] smsutil: Fix valgrind complaint SMS cannot be split over GSM extension chars, however on the last segment this code was causing us to overflow the buffer and resulted in valgrind complaining. --- src/smsutil.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 14dc43a..e41c041 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2936,12 +2936,12 @@ GSList *sms_text_prepare(const char *utf8, guint16 ref, if (gsm_encoded) { chunk = sms_text_capacity_gsm(160, offset); - if (gsm_encoded[written + chunk - 1] == 0x1b) - chunk -= 1; - if (left < chunk) chunk = left; + if (gsm_encoded[written + chunk - 1] == 0x1b) + chunk -= 1; + template.submit.udl = chunk + (offset * 8 + 6) / 7; pack_7bit_own_buf(gsm_encoded + written, chunk, offset, FALSE, NULL, 0, -- 2.7.4