From e68fa6f07666ec4726cfef59f641a81244cc2e00 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 15 Sep 2015 19:29:37 +0100 Subject: [PATCH] gdb/doc: revert previous vforkdone change The previous manual change was wrong. The vfork parent thread ID should be reported with the usual "thread" magic register: Sending packet: $vCont;c:p7260.7260#1e...Packet received: OK - Notification received: Stop:T05vforkdone:; + Notification received: Stop:T05vforkdone:;thread:p7260.7260 ^^^^^^^^^^^^^^^^^ This is already how the parent is reported in the vfork/fork events, and is actually what the fix made gdbserver do. Following the documentation change, the event would have been reported like this instead: Notification received: Stop:T05vforkdone:p7260.7260 gdb/doc/ChangeLog: 2015-09-15 Pedro Alves PR remote/18965 * gdb.texinfo (Stop Reply Packets): Revert previous change to the vforkdone description. --- gdb/doc/ChangeLog | 6 ++++++ gdb/doc/gdb.texinfo | 11 +++++------ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 2cc6039..1e16e92 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,6 +1,12 @@ 2015-09-15 Pedro Alves PR remote/18965 + * gdb.texinfo (Stop Reply Packets): Revert previous change to + the vforkdone description. + +2015-09-15 Pedro Alves + + PR remote/18965 * gdb.texinfo (Stop Reply Packets): Explain that vforkdone's 'r' part indicates the thread ID of the parent process. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index e80e695..4ecdb8f 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -35498,12 +35498,11 @@ indicating support. @cindex vforkdone events, remote reply @item vforkdone -The packet indicates that a child process created by a vfork has -either called @code{exec} or terminated, so that the address spaces of -the parent and child process are no longer shared. The @var{r} part -is the thread ID of the parent process. Refer to @ref{thread-id -syntax} for the format of the @var{thread-id} field. This packet is -only applicable to targets that support vforkdone events. +The packet indicates that a child process created by a vfork +has either called @code{exec} or terminated, so that the +address spaces of the parent and child process are no longer +shared. The @var{r} part is ignored. This packet is only +applicable to targets that support vforkdone events. This packet should not be sent by default; older @value{GDBN} versions did not support it. @value{GDBN} requests it, by supplying an -- 2.7.4