From e641288834b9beefb19d11ceb28616038bd9b2cd Mon Sep 17 00:00:00 2001 From: "eric@webkit.org" Date: Thu, 26 Jan 2012 00:17:59 +0000 Subject: [PATCH] HTMLIsIndexElement should not expose HTMLInputElement properties https://bugs.webkit.org/show_bug.cgi?id=76095 Reviewed by Adam Barth. Source/WebCore: document.createElement("isindex") should produce an HTMLUnknownElement per the HTML5 spec. The parser automagically translates into a whole dom tree roughly representing what used to do 15 years ago. :) This patch just removes our support for HTMLIsIndexElement. The parser support was already in. Having support for HTMLIsIndexElement was causing one of the IE TestCenter tests to fail. Test: fast/dom/HTMLIsIndexElement/prototype-chain.html * DerivedSources.cpp: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * Target.pri: * WebCore.exp.in: * WebCore.gypi: * WebCore.order: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/gobject/GNUmakefile.am: * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createHTMLElementWrapper): * bindings/objc/DOM.mm: (WebCore::createElementClassMap): * bindings/objc/DOMHTML.h: * bindings/objc/PublicDOMInterfaces.h: * html/HTMLElementsAllInOne.cpp: * html/HTMLIsIndexElement.cpp: Removed. * html/HTMLIsIndexElement.h: Removed. * html/HTMLIsIndexElement.idl: Removed. * html/HTMLTagNames.in: * page/DOMWindow.idl: Source/WebKit/mac: * MigrateHeaders.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105940 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 41 ++++++++++++++++++++++++++++++++++++++ Source/WebCore/DerivedSources.cpp | 1 - Source/WebCore/DerivedSources.make | 1 - Source/WebCore/DerivedSources.pri | 1 - Source/WebKit/mac/ChangeLog | 9 +++++++++ 5 files changed, 50 insertions(+), 3 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 9065227..8cb3919 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,5 +1,46 @@ 2012-01-25 Eric Seidel + HTMLIsIndexElement should not expose HTMLInputElement properties + https://bugs.webkit.org/show_bug.cgi?id=76095 + + Reviewed by Adam Barth. + + document.createElement("isindex") should produce an HTMLUnknownElement + per the HTML5 spec. The parser automagically translates into + a whole dom tree roughly representing what used to do 15 years ago. :) + + This patch just removes our support for HTMLIsIndexElement. The parser + support was already in. Having support for HTMLIsIndexElement was causing + one of the IE TestCenter tests to fail. + + Test: fast/dom/HTMLIsIndexElement/prototype-chain.html + + * DerivedSources.cpp: + * DerivedSources.make: + * DerivedSources.pri: + * GNUmakefile.list.am: + * Target.pri: + * WebCore.exp.in: + * WebCore.gypi: + * WebCore.order: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/gobject/GNUmakefile.am: + * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: + (WebKit::createHTMLElementWrapper): + * bindings/objc/DOM.mm: + (WebCore::createElementClassMap): + * bindings/objc/DOMHTML.h: + * bindings/objc/PublicDOMInterfaces.h: + * html/HTMLElementsAllInOne.cpp: + * html/HTMLIsIndexElement.cpp: Removed. + * html/HTMLIsIndexElement.h: Removed. + * html/HTMLIsIndexElement.idl: Removed. + * html/HTMLTagNames.in: + * page/DOMWindow.idl: + +2012-01-25 Eric Seidel + HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload https://bugs.webkit.org/show_bug.cgi?id=74360 diff --git a/Source/WebCore/DerivedSources.cpp b/Source/WebCore/DerivedSources.cpp index 5fa5e00..2b02361 100644 --- a/Source/WebCore/DerivedSources.cpp +++ b/Source/WebCore/DerivedSources.cpp @@ -168,7 +168,6 @@ #include "JSHTMLIFrameElement.cpp" #include "JSHTMLImageElement.cpp" #include "JSHTMLInputElement.cpp" -#include "JSHTMLIsIndexElement.cpp" #include "JSHTMLKeygenElement.cpp" #include "JSHTMLLabelElement.cpp" #include "JSHTMLLegendElement.cpp" diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make index 64be83d..500509b 100644 --- a/Source/WebCore/DerivedSources.make +++ b/Source/WebCore/DerivedSources.make @@ -215,7 +215,6 @@ BINDING_IDLS = \ $(WebCore)/html/HTMLIFrameElement.idl \ $(WebCore)/html/HTMLImageElement.idl \ $(WebCore)/html/HTMLInputElement.idl \ - $(WebCore)/html/HTMLIsIndexElement.idl \ $(WebCore)/html/HTMLKeygenElement.idl \ $(WebCore)/html/HTMLLIElement.idl \ $(WebCore)/html/HTMLLabelElement.idl \ diff --git a/Source/WebCore/DerivedSources.pri b/Source/WebCore/DerivedSources.pri index 5b9f0f67..0347090 100644 --- a/Source/WebCore/DerivedSources.pri +++ b/Source/WebCore/DerivedSources.pri @@ -280,7 +280,6 @@ IDL_BINDINGS += \ $$PWD/html/HTMLIFrameElement.idl \ $$PWD/html/HTMLImageElement.idl \ $$PWD/html/HTMLInputElement.idl \ - $$PWD/html/HTMLIsIndexElement.idl \ $$PWD/html/HTMLKeygenElement.idl \ $$PWD/html/HTMLLabelElement.idl \ $$PWD/html/HTMLLegendElement.idl \ diff --git a/Source/WebKit/mac/ChangeLog b/Source/WebKit/mac/ChangeLog index 589c18e..f09d319 100644 --- a/Source/WebKit/mac/ChangeLog +++ b/Source/WebKit/mac/ChangeLog @@ -1,3 +1,12 @@ +2012-01-25 Eric Seidel + + HTMLIsIndexElement should not expose HTMLInputElement properties + https://bugs.webkit.org/show_bug.cgi?id=76095 + + Reviewed by Adam Barth. + + * MigrateHeaders.make: + 2012-01-25 Hajime Morita ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom -- 2.7.4