From e607477d7ca2550c0b7f53f3886b4b6fd055d779 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Fri, 11 Sep 2020 16:00:07 -0700 Subject: [PATCH] freedreno: Check file descriptor before write. Fix defect reported by Coverity Scan. Argument cannot be negative (NEGATIVE_RETURNS) negative_returns: fd is passed to a parameter that cannot be negative. Fixes: 1ea4ef0d3be8 ("freedreno: slurp in decode tools") Signed-off-by: Vinson Lee Reviewed-by: Rob Clark Part-of: --- src/freedreno/decode/cffdec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/freedreno/decode/cffdec.c b/src/freedreno/decode/cffdec.c index a790ca2..b698e23 100644 --- a/src/freedreno/decode/cffdec.c +++ b/src/freedreno/decode/cffdec.c @@ -403,8 +403,10 @@ dump_shader(const char *ext, void *buf, int bufsz) int fd; sprintf(filename, "%04d.%s", n++, ext); fd = open(filename, O_WRONLY| O_TRUNC | O_CREAT, 0644); - write(fd, buf, bufsz); - close(fd); + if (fd != -1) { + write(fd, buf, bufsz); + close(fd); + } } } -- 2.7.4