From e5ec22e6ad951f99c1b576417480b8e598a84ad0 Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Wed, 13 Dec 2017 09:17:43 +0100 Subject: [PATCH] linux_udev: Initialize pointer before calling external API udev_list_entry_foreach() sets the entry variable for each device but initializing the pointer to NULL to avoid warnings. Found by Coverity: libusb-1.0.21/libusb/os/linux_udev.c:273: error[uninitvar]: Uninitialized variable: entry > 271| devices = udev_enumerate_get_list_entry(enumerator); > 272| > 273|-> udev_list_entry_foreach(entry, devices) { > 274| const char *path = udev_list_entry_get_name(entry); > 275| uint8_t busnum = 0, devaddr = 0; Signed-off-by: Victor Toso Signed-off-by: Chris Dickens --- libusb/os/linux_udev.c | 1 + libusb/version_nano.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libusb/os/linux_udev.c b/libusb/os/linux_udev.c index 67d7e39..c97806b 100644 --- a/libusb/os/linux_udev.c +++ b/libusb/os/linux_udev.c @@ -291,6 +291,7 @@ int linux_udev_scan_devices(struct libusb_context *ctx) udev_enumerate_scan_devices(enumerator); devices = udev_enumerate_get_list_entry(enumerator); + entry = NULL; udev_list_entry_foreach(entry, devices) { const char *path = udev_list_entry_get_name(entry); uint8_t busnum = 0, devaddr = 0; diff --git a/libusb/version_nano.h b/libusb/version_nano.h index 4c701ea..277c3fd 100644 --- a/libusb/version_nano.h +++ b/libusb/version_nano.h @@ -1 +1 @@ -#define LIBUSB_NANO 11219 +#define LIBUSB_NANO 11220 -- 2.7.4