From e5dc4ede3a814d994be03932489b7ba6007c34a1 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 3 Jun 2003 21:53:15 +0000 Subject: [PATCH] - marked piece of wrong code in the state change function with a FIXME Original commit message from CVS: - marked piece of wrong code in the state change function with a FIXME --- gst/gstbin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst/gstbin.c b/gst/gstbin.c index 726d291..194abcc 100644 --- a/gst/gstbin.c +++ b/gst/gstbin.c @@ -689,6 +689,8 @@ gst_bin_change_state (GstElement * element) GST_ELEMENT_NAME (child), pending, gst_element_state_get_name (pending)); gst_element_set_state (child, old_child_state); + /* FIXME, this is legacy code, a failed state change of a child should + * return a failure in all cases */ if (GST_ELEMENT_SCHED (child) == GST_ELEMENT_SCHED (element)) { /* try to reset it to what is was */ GST_STATE_PENDING (element) = old_state; -- 2.7.4