From e5c5f92e12827fcf969002b1472b6ad9c08b1f14 Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Fri, 10 Jun 2022 21:54:09 +0100 Subject: [PATCH] [InstCombine] switch synthetic unreachable to use undef instead of poison (NFC) --- llvm/lib/Transforms/InstCombine/InstCombineInternal.h | 4 ++-- llvm/test/Transforms/InstCombine/element-atomic-memintrins.ll | 2 +- llvm/test/Transforms/InstCombine/pr44245.ll | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Transforms/InstCombine/InstCombineInternal.h b/llvm/lib/Transforms/InstCombine/InstCombineInternal.h index 6340c99..dcfc32f 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineInternal.h +++ b/llvm/lib/Transforms/InstCombine/InstCombineInternal.h @@ -411,7 +411,7 @@ public: // If we are replacing the instruction with itself, this must be in a // segment of unreachable code, so just clobber the instruction. if (&I == V) - V = UndefValue::get(I.getType()); + V = PoisonValue::get(I.getType()); LLVM_DEBUG(dbgs() << "IC: Replacing " << I << "\n" << " with " << *V << '\n'); @@ -439,7 +439,7 @@ public: void CreateNonTerminatorUnreachable(Instruction *InsertAt) { auto &Ctx = InsertAt->getContext(); new StoreInst(ConstantInt::getTrue(Ctx), - UndefValue::get(Type::getInt1PtrTy(Ctx)), + PoisonValue::get(Type::getInt1PtrTy(Ctx)), InsertAt); } diff --git a/llvm/test/Transforms/InstCombine/element-atomic-memintrins.ll b/llvm/test/Transforms/InstCombine/element-atomic-memintrins.ll index 183e22e..9e0d1ee3 100644 --- a/llvm/test/Transforms/InstCombine/element-atomic-memintrins.ll +++ b/llvm/test/Transforms/InstCombine/element-atomic-memintrins.ll @@ -420,7 +420,7 @@ define void @test_undefined(i8* %dest, i8* %src, i1 %c1) { ; CHECK-NEXT: entry: ; CHECK-NEXT: br i1 [[C1:%.*]], label [[OK:%.*]], label [[UNDEFINED:%.*]] ; CHECK: undefined: -; CHECK-NEXT: store i1 true, i1* undef, align 1 +; CHECK-NEXT: store i1 true, i1* poison, align 1 ; CHECK-NEXT: br label [[OK]] ; CHECK: ok: ; CHECK-NEXT: ret void diff --git a/llvm/test/Transforms/InstCombine/pr44245.ll b/llvm/test/Transforms/InstCombine/pr44245.ll index 1c12345..3ecd9028 100644 --- a/llvm/test/Transforms/InstCombine/pr44245.ll +++ b/llvm/test/Transforms/InstCombine/pr44245.ll @@ -59,7 +59,7 @@ define void @test(i1 %c) { ; CHECK-NEXT: br label [[BB47]] ; CHECK: bb152: ; CHECK-NEXT: [[TMP1848]] = load i8*, i8** inttoptr (i64 16 to i8**), align 16 -; CHECK-NEXT: store i1 true, i1* undef, align 1 +; CHECK-NEXT: store i1 true, i1* poison, align 1 ; CHECK-NEXT: br label [[BB150]] ; bb16: ; preds = %bb -- 2.7.4