From e5b7882f55674eccebed9b9ba58de3a21bd0efb1 Mon Sep 17 00:00:00 2001 From: "Craig A. Berry" Date: Sun, 23 Mar 2014 13:33:49 -0500 Subject: [PATCH] Remove MM_TEST_ROOT feature from ExtUtils::Install tests. This feature depended on test directories created on the fly being in a predictable location, but as of 80af860fb39a3c6 they no longer are. VMS systems released in the last 15 years or so don't even need the feature, so the best path forward is to get rid of it. A corresponding change was made in ExtUtils::MakeMaker 6.79_01 but ExtUtils::Install maintains its own fork of the same test libraries. --- dist/ExtUtils-Install/lib/ExtUtils/Install.pm | 4 ++-- .../t/lib/MakeMaker/Test/Setup/BFD.pm | 6 +---- .../ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm | 27 ---------------------- 3 files changed, 3 insertions(+), 34 deletions(-) diff --git a/dist/ExtUtils-Install/lib/ExtUtils/Install.pm b/dist/ExtUtils-Install/lib/ExtUtils/Install.pm index a55395c..721838d 100644 --- a/dist/ExtUtils-Install/lib/ExtUtils/Install.pm +++ b/dist/ExtUtils-Install/lib/ExtUtils/Install.pm @@ -38,11 +38,11 @@ ExtUtils::Install - install files from here to there =head1 VERSION -1.63 +1.64 =cut -$VERSION = '1.63'; # <-- do not forget to update the POD section just above this line! +$VERSION = '1.64'; # <-- do not forget to update the POD section just above this line! $VERSION = eval $VERSION; =pod diff --git a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Setup/BFD.pm b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Setup/BFD.pm index 9745656..868d0b9 100644 --- a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Setup/BFD.pm +++ b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Setup/BFD.pm @@ -9,13 +9,11 @@ use File::Path; use File::Basename; use MakeMaker::Test::Utils; -my $Is_VMS = $^O eq 'VMS'; - my %Files = ( 'Big-Dummy/lib/Big/Dummy.pm' => <<'END', package Big::Dummy; -$VERSION = 0.01; +$VERSION = 0.02; =head1 NAME @@ -96,8 +94,6 @@ END sub setup_recurs { - setup_mm_test_root(); - chdir 'MM_TEST_ROOT:[t]' if $Is_VMS; while(my($file, $text) = each %Files) { # Convert to a relative, native file path. diff --git a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm index ca3b46f..8d5ee1a 100644 --- a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm +++ b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm @@ -12,7 +12,6 @@ our $Is_MacOS = $^O eq 'MacOS'; our @EXPORT = qw(which_perl perl_lib makefile_name makefile_backup make make_run run make_macro calibrate_mtime - setup_mm_test_root have_compiler slurp $Is_VMS $Is_MacOS run_ok @@ -335,32 +334,6 @@ sub run_ok { return wantarray ? @out : join "", @out; } -=item B - -Creates a rooted logical to avoid the 8-level limit on older VMS systems. -No action taken on non-VMS systems. - -=cut - -sub setup_mm_test_root { - if( $Is_VMS ) { - # On older systems we might exceed the 8-level directory depth limit - # imposed by RMS. We get around this with a rooted logical, but we - # can't create logical names with attributes in Perl, so we do it - # in a DCL subprocess and put it in the job table so the parent sees it. - open( MMTMP, '>mmtesttmp.com' ) || - die "Error creating command file; $!"; - print MMTMP <<'COMMAND'; -$ MM_TEST_ROOT = F$PARSE("SYS$DISK:[--]",,,,"NO_CONCEAL")-".][000000"-"]["-"].;"+".]" -$ DEFINE/JOB/NOLOG/TRANSLATION=CONCEALED MM_TEST_ROOT 'MM_TEST_ROOT' -COMMAND - close MMTMP; - - system '@mmtesttmp.com'; - 1 while unlink 'mmtesttmp.com'; - } -} - =item have_compiler $have_compiler = have_compiler; -- 2.7.4