From e594478edf0c8ac6756d5889fd3716e05e31b807 Mon Sep 17 00:00:00 2001 From: Jin-Seong Kim Date: Wed, 2 Aug 2017 09:26:12 +0900 Subject: [PATCH] netutils/webserver : Fix problems from static analysis tool This commit is patch for fixing problems from static analysis tool - to resolve issues of unchecked function returns Change-Id: I456698096d4887d8f64c896db4f614cea692ca40 Signed-off-by: Jin-Seong Kim Signed-off-by: EunBong Song --- apps/netutils/webclient/webclient.c | 6 +++++- apps/netutils/webserver/http.c | 5 ++++- apps/netutils/webserver/http_client.c | 5 ++++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/apps/netutils/webclient/webclient.c b/apps/netutils/webclient/webclient.c index 7ab8b4c..0cf8cef 100644 --- a/apps/netutils/webclient/webclient.c +++ b/apps/netutils/webclient/webclient.c @@ -1272,7 +1272,11 @@ int client_send_request(struct http_client_request_t *request) if (request->callback) { request->async_flag = 1; - pthread_attr_init(&attr); + if (pthread_attr_init(&attr) != 0) { + printf("Error: Cannot initialize thread attribute\n"); + goto errret; + } + pthread_attr_setstacksize(&attr, CLIENT_REQ_THREAD_STACK); if (pthread_create(&tid, &attr, wget_base, (void *)request) != 0) { diff --git a/apps/netutils/webserver/http.c b/apps/netutils/webserver/http.c index c83a73c..c7c80a3 100644 --- a/apps/netutils/webserver/http.c +++ b/apps/netutils/webserver/http.c @@ -293,7 +293,10 @@ int http_server_start(struct http_server_t *server) #endif for (i = 0; i < HTTP_CONF_MAX_CLIENT_HANDLE; i++) { - pthread_attr_init(&attr); + if (pthread_attr_init(&attr) != 0) { + HTTP_LOGE("Error: Cannot initialize thread attribute\n"); + return HTTP_ERROR; + } pthread_attr_setschedpolicy(&attr, SCHED_RR); pthread_attr_setstacksize(&attr, cli_handle_stack); if (pthread_create(&server->c_tid[i], &attr, http_handle_client, (void *)server) != 0) { diff --git a/apps/netutils/webserver/http_client.c b/apps/netutils/webserver/http_client.c index beec74d..d7e329f 100644 --- a/apps/netutils/webserver/http_client.c +++ b/apps/netutils/webserver/http_client.c @@ -460,7 +460,10 @@ int http_recv_and_handle_request(struct http_client_t *client, struct http_keyva mbedtls_ssl_set_bio(ws->tls_ssl, &ws->tls_net, mbedtls_net_send, mbedtls_net_recv, NULL); } #endif - pthread_attr_init(&ws->thread_attr); + if (pthread_attr_init(&ws->thread_attr) != 0) { + HTTP_LOGE("Error: Cannot initialize thread attribute\n"); + goto errout; + } pthread_attr_setstacksize(&ws->thread_attr, WEBSOCKET_STACKSIZE); pthread_attr_setschedpolicy(&ws->thread_attr, SCHED_RR); if (pthread_create(&ws->thread_id, &ws->thread_attr, -- 2.7.4