From e560ce0909693994e9b7e794f9904805c052ebcd Mon Sep 17 00:00:00 2001 From: Mark Nauwelaerts Date: Mon, 21 May 2012 15:24:25 +0200 Subject: [PATCH] codecparsers: mpegvideoparser: fix buffer size check ... to mind unsigned integer wrap Based on patch by Alban Browaeys Fixes https://bugzilla.gnome.org/show_bug.cgi?id=673436 --- gst-libs/gst/codecparsers/gstmpegvideoparser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gst-libs/gst/codecparsers/gstmpegvideoparser.c b/gst-libs/gst/codecparsers/gstmpegvideoparser.c index ec8c934..5c84268 100644 --- a/gst-libs/gst/codecparsers/gstmpegvideoparser.c +++ b/gst-libs/gst/codecparsers/gstmpegvideoparser.c @@ -298,19 +298,19 @@ gst_mpeg_video_parse (const guint8 * data, gsize size, guint offset) GstByteReader br; GList *ret = NULL; - size -= offset; - if (!initialized) { GST_DEBUG_CATEGORY_INIT (mpegvideo_parser_debug, "codecparsers_mpegvideo", 0, "Mpegvideo parser library"); initialized = TRUE; } - if (size <= 0) { + if (size <= offset) { GST_DEBUG ("Can't parse from offset %d, buffer is to small", offset); return NULL; } + size -= offset; + gst_byte_reader_init (&br, &data[offset], size); off = scan_for_start_codes (&br, 0, size); -- 2.7.4