From e54b70b3d4e88c71b47a9123d496dd05e0e056cd Mon Sep 17 00:00:00 2001 From: Topi Pohjolainen Date: Thu, 8 Sep 2016 08:22:38 +0300 Subject: [PATCH] i965/rbc: Clarify rational given for shader image resolves Original commit added documentation explaining lossless compression case: commit 56f29911ec9da25c78fbd3d4945d499e65ca4b5a Author: Topi Pohjolainen Date: Tue Feb 2 10:00:41 2016 +0200 i965: Add a flag telling color resolve pass to ignore CCS_E It, however, easily gives the impression that the sole purpose of the intel_miptree_resolve_color() is to address lossless compression. Original intention is to document the lack of INTEL_MIPTREE_IGNORE_CCS_E flag given for the resolve call. This patch fixes this along with a typo found spotted further down. Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_context.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 0e36d47..c28401a6 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++ b/src/mesa/drivers/dri/i965/brw_context.c @@ -283,8 +283,9 @@ intel_update_state(struct gl_context * ctx, GLuint new_state) /* Access to images is implemented using indirect messages * against data port. Normal render target write understands * lossless compression but unfortunately the typed/untyped - * read/write interface doesn't. Therefore the compressed - * surfaces need to be resolved prior to accessing them. + * read/write interface doesn't. Therefore even lossless + * compressed surfaces need to be resolved prior to accessing + * them. Hence skip setting INTEL_MIPTREE_IGNORE_CCS_E. */ intel_miptree_resolve_color(brw, tex_obj->mt, 0); @@ -300,7 +301,7 @@ intel_update_state(struct gl_context * ctx, GLuint new_state) } } - /* Resolve color buffers for non-coherent framebufer fetch. */ + /* Resolve color buffers for non-coherent framebuffer fetch. */ if (!ctx->Extensions.MESA_shader_framebuffer_fetch && ctx->FragmentProgram._Current && ctx->FragmentProgram._Current->Base.OutputsRead) { -- 2.7.4