From e52c03ff4a3ef5525649d16eba9af0d0cde4c27f Mon Sep 17 00:00:00 2001 From: Rafal Krypa Date: Mon, 17 Sep 2012 15:38:30 +0200 Subject: [PATCH] Smack: prevent revoke-subject from failing when unseen label is written to it commit d15d9fad16f6aa459cf4926a1d3aba36b004e9a2 upstream Special file /smack/revoke-subject will silently accept labels, that are not present on the subject label list. Nothing has to be done for such labels, as there are no rules for them to revoke. Change-Id: I326e1fad79a99a48839de8c35abfe709391e0f30 Signed-off-by: Rafal Krypa Reviewed-on: http://165.213.202.130:8080/53903 Reviewed-by: Kyungmin Park Tested-by: Kyungmin Park --- security/smack/smackfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 84d13e04d68c..952789b95cc0 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -2076,10 +2076,8 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf, } skp = smk_find_entry(cp); - if (skp == NULL) { - rc = -EINVAL; + if (skp == NULL) goto free_out; - } rule_list = &skp->smk_rules; rule_lock = &skp->smk_rules_lock; -- 2.34.1