From e52786ac3ca721636a6fb0ae88521f5b9ece88a3 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Sat, 4 Apr 2015 16:59:29 +0200 Subject: [PATCH] clk: versatile: test returned value Put NULL test on the result of the previous call instead on one of its arguments. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr/): // r@ expression *e1; expression *e2; identifier f; statement S1,S2; @@ e1 = f(...,e2,...); ( if (e1 == NULL || ...) S1 else S2 | *if (e2 == NULL || ...) S1 else S2 ) // Signed-off-by: Julia Lawall Acked-by: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/clk/versatile/clk-versatile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c index a76981e..7a4f863 100644 --- a/drivers/clk/versatile/clk-versatile.c +++ b/drivers/clk/versatile/clk-versatile.c @@ -69,7 +69,7 @@ static void __init cm_osc_setup(struct device_node *np, struct device_node *parent; parent = of_get_parent(np); - if (!np) { + if (!parent) { pr_err("no parent on core module clock\n"); return; } -- 2.7.4