From e4ed852041fc890706d2b002bb24d33078ba47ae Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Sun, 25 Jan 2015 17:30:33 +0100 Subject: [PATCH] rtpsession: Deprecate rtcp-immediate-feedback-threshold property It had no effect since quite some time and also is not needed in general, especially not to switch between immediate feedback mode and early feedback mode. The latest understanding of the RFC is that from the endpoint point of view, both modes are exactly the same. RTCP is only allowed to use the bandwidth as given by the RFC constraints, as such it is only ever possible to schedule a RTCP packet early but it's against the RFC to schedule more RTCP packets. The difference between immediate feedback mode and early feedback mode is that the former guarantees that an RTCP packet can be sent for every event "immediately", which means that the bandwidth calculations from the RFC have resulted in an RTCP scheduling interval that is small enough. Early feedback mode on the other hand means that we can schedule some packets early to make that happen, but it's not guaranteed at all that it's possible to schedule an RTCP packet per event (i.e. they need to be accumulated or dropped). --- gst/rtpmanager/rtpsession.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/rtpmanager/rtpsession.c b/gst/rtpmanager/rtpsession.c index 2c49fb1..d5af155 100644 --- a/gst/rtpmanager/rtpsession.c +++ b/gst/rtpmanager/rtpsession.c @@ -450,9 +450,9 @@ rtp_session_class_init (RTPSessionClass * klass) g_param_spec_uint ("rtcp-immediate-feedback-threshold", "RTCP Immediate Feedback threshold", "The maximum number of members of a RTP session for which immediate" - " feedback is used", + " feedback is used (DEPRECATED: has no effect and is not needed)", 0, G_MAXUINT, DEFAULT_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD, - G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_DEPRECATED)); g_object_class_install_property (gobject_class, PROP_PROBATION, g_param_spec_uint ("probation", "Number of probations", -- 2.7.4