From e4b2ab47d825bf19c3a69c9c70308ea6c534d071 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 4 Jul 2019 16:10:18 +0300 Subject: [PATCH] [netcore] Make System.Reflection.Tests.TypeTests.GetEnumUnderlyingType Pass (mono/mono#15510) * [netcore] Make System.Reflection.Tests.TypeTests.GetEnumUnderlyingType Pass * Remove recursive name parsing in case of "+" character; remove if condition for nested names Commit migrated from https://github.com/mono/mono/commit/e0da61d691e79ae810f40b2eef2d30647d30ff72 --- src/mono/netcore/CoreFX.issues.rsp | 4 ---- src/mono/netcore/System.Private.CoreLib/src/System/TypeNameParser.cs | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index e1ce305..982c3c8 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -1208,10 +1208,6 @@ # https://github.com/mono/mono/issues/15349 -nomethod System.Reflection.Tests.TypeTests.TypesWithStrangeCharacters -# System.ArgumentException : Type provided must be an enum. -# https://github.com/mono/mono/issues/15350 --nomethod System.Reflection.Tests.TypeTests.GetEnumUnderlyingType - # Assertion failure: Expected: 1, Actual: 0 # https://github.com/mono/mono/issues/15351 -nomethod System.Reflection.Tests.TypeTests_HiddenTestingOrder.HideDetectionHappensAfterPrivateInBaseClassChecks diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/TypeNameParser.cs b/src/mono/netcore/System.Private.CoreLib/src/System/TypeNameParser.cs index c0d548f..f1e5ec7 100644 --- a/src/mono/netcore/System.Private.CoreLib/src/System/TypeNameParser.cs +++ b/src/mono/netcore/System.Private.CoreLib/src/System/TypeNameParser.cs @@ -244,8 +244,7 @@ namespace System pos ++; } - if (res.Names.Count == 0) - res.Names.Add (name.Substring (name_start, pos - name_start)); + res.Names.Add (name.Substring (name_start, pos - name_start)); bool isbyref = false; bool isptr = false; -- 2.7.4