From e426ae2bd5e04ca57f36bfb64a5a466a6797cea1 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 5 Oct 2020 22:54:22 +0100 Subject: [PATCH] [libcxx][dsl] Fix mutable default argument warning This is flagged by PyCharm and can cause subtle bugs. While changing this also re-sort the imports and add missing ones. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D88816 --- libcxx/utils/libcxx/test/dsl.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libcxx/utils/libcxx/test/dsl.py b/libcxx/utils/libcxx/test/dsl.py index 95d23df..820a5b3 100644 --- a/libcxx/utils/libcxx/test/dsl.py +++ b/libcxx/utils/libcxx/test/dsl.py @@ -6,15 +6,20 @@ # #===----------------------------------------------------------------------===## -import libcxx.test.format -import lit -import lit.util import os import pipes import platform import re import tempfile +import libcxx.test.format +import lit +import lit.LitConfig +import lit.Test +import lit.TestRunner +import lit.util + + def _memoize(f): cache = dict() def memoized(x): @@ -83,7 +88,7 @@ def sourceBuilds(config, source): _executeScriptInternal(test, ['rm %t.exe']) return exitCode == 0 -def programOutput(config, program, args=[], testPrefix=''): +def programOutput(config, program, args=None, testPrefix=''): """ Compiles a program for the test target, run it on the test target and return the output. @@ -92,6 +97,8 @@ def programOutput(config, program, args=[], testPrefix=''): execution of the program is done through the %{exec} substitution, which means that the program may be run on a remote host depending on what %{exec} does. """ + if args is None: + args = [] with _makeConfigTest(config, testPrefix=testPrefix) as test: with open(test.getSourcePath(), 'w') as source: source.write(program) -- 2.7.4