From e3af6b1821eae95a680519fa4fa325af00c6e84e Mon Sep 17 00:00:00 2001 From: "mvstanton@chromium.org" Date: Tue, 1 Jul 2014 14:51:11 +0000 Subject: [PATCH] Test mjsunit/allocation-site-info is flaky without explicit gc() It started failing on arm64 nosnap during a test case where complex nested literal arrays are created. R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/367703002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/allocation-site-info.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/mjsunit/allocation-site-info.js b/test/mjsunit/allocation-site-info.js index 35b60ee..0545754 100644 --- a/test/mjsunit/allocation-site-info.js +++ b/test/mjsunit/allocation-site-info.js @@ -414,6 +414,11 @@ if (support_smi_only_arrays) { assertKind(elements_kind.fast, obj[1][0]); })(); + // Perform a gc because without it the test below can experience an + // allocation failure at an inconvenient point. Allocation mementos get + // cleared on gc, and they can't deliver elements kind feedback when that + // happens. + gc(); // Make sure object literals with array fields benefit from the type feedback // that allocation mementos provide. -- 2.7.4