From e38273013bab16f738f18d1658a3bbf88fa8a025 Mon Sep 17 00:00:00 2001 From: Rajnesh Kanwal Date: Wed, 5 Oct 2022 16:34:24 +0500 Subject: [PATCH] pvr: Change CDM to compute, TA to geometry and 3D to fragment. Signed-off-by: Rajnesh Kanwal Reviewed-by: Frank Binns Part-of: --- src/imagination/vulkan/pvr_cmd_buffer.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/imagination/vulkan/pvr_cmd_buffer.c b/src/imagination/vulkan/pvr_cmd_buffer.c index 7556d47..68712fd 100644 --- a/src/imagination/vulkan/pvr_cmd_buffer.c +++ b/src/imagination/vulkan/pvr_cmd_buffer.c @@ -1163,9 +1163,9 @@ pvr_compute_flat_slot_size(const struct pvr_physical_device *pdevice, * number of coefficients allow us to have. */ if (coeff_regs_count > 0U) { - /* If TA or 3D can overlap with CDM, or if the TA is running a geometry - * shader then we need to consider this in calculating max allowed - * work-groups. + /* If the geometry or fragment jobs can overlap with the compute job, or + * if there is a vertex shader already running then we need to consider + * this in calculating max allowed work-groups. */ if (PVR_HAS_QUIRK(dev_info, 52354) && (PVR_HAS_FEATURE(dev_info, compute_overlap) || @@ -6115,12 +6115,13 @@ void pvr_CmdPipelineBarrier2(VkCommandBuffer commandBuffer, } /* Multiple dispatches can be merged into a single job. When back to - * back dispatches have a sequential dependency (CDM -> CDM pipeline - * barrier) we need to do the following. + * back dispatches have a sequential dependency (Compute -> compute + * pipeline barrier) we need to do the following. * - Dispatch a kernel which fences all previous memory writes and * flushes the MADD cache. - * - Issue a CDM fence which ensures all previous tasks emitted by - * the CDM are completed before starting anything new. + * - Issue a compute fence which ensures all previous tasks emitted + * by the compute data master are completed before starting + * anything new. */ /* Issue Data Fence, Wait for Data Fence (IDFWDF) makes the PDS wait -- 2.7.4