From e34f79c9182f0beafaec6d254df168515e219568 Mon Sep 17 00:00:00 2001 From: Alexandros Frantzis Date: Tue, 28 May 2019 00:06:03 +0300 Subject: [PATCH] virgl: Remove incorrect resource wait condition Now that we have copy transfers in place, we can remove the incorrect resource wait condition. Copy transfers and other optimizations minimize the performance impact of this removal, while providing the correct behavior. Signed-off-by: Alexandros Frantzis Reviewed-by: Chia-I Wu --- src/gallium/drivers/virgl/virgl_resource.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_resource.c b/src/gallium/drivers/virgl/virgl_resource.c index 897e0c1..879c3fb 100644 --- a/src/gallium/drivers/virgl/virgl_resource.c +++ b/src/gallium/drivers/virgl/virgl_resource.c @@ -155,19 +155,6 @@ virgl_resource_transfer_prepare(struct virgl_context *vctx, flush = true; } - /* XXX This is incorrect and will be removed. Consider - * - * glTexImage2D(..., data1); - * glDrawArrays(); - * glFlush(); - * glTexImage2D(..., data2); - * - * readback and flush are both false in the second glTexImage2D call. The - * draw call might end up seeing data2. Same applies to buffers with - * glBufferSubData. - */ - wait = flush || readback; - if (flush) vctx->base.flush(&vctx->base, NULL, 0); -- 2.7.4