From e3470ae4bd75f77426cc2f4053d84483832406ef Mon Sep 17 00:00:00 2001 From: Gregory Chanan Date: Fri, 19 Apr 2019 11:23:53 -0700 Subject: [PATCH] Revert D15003379: Have _embedding_bag_dense_backward match JIT signature. Differential Revision: D15003379 Original commit changeset: f8e82800171f fbshipit-source-id: 55f83557998d166aeb41d00d7a590acdc76fcf22 --- aten/src/ATen/native/native_functions.yaml | 3 ++- tools/autograd/derivatives.yaml | 7 ------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/aten/src/ATen/native/native_functions.yaml b/aten/src/ATen/native/native_functions.yaml index 256d51e..2af6585 100644 --- a/aten/src/ATen/native/native_functions.yaml +++ b/aten/src/ATen/native/native_functions.yaml @@ -668,7 +668,8 @@ - func: _embedding_bag_sparse_backward(Tensor grad, Tensor indices, Tensor offsets, Tensor offset2bag, Tensor bag_size, int num_weights, bool scale_grad_by_freq, int mode, Tensor? per_sample_weights) -> Tensor -- func: _embedding_bag_dense_backward(Tensor grad, Tensor indices, Tensor offsets, Tensor offset2bag, Tensor bag_size, Tensor maximum_indices, int num_weights, bool scale_grad_by_freq, int mode, Tensor? per_sample_weights) -> Tensor +- func: _embedding_bag_dense_backward(Tensor grad, IndexTensor indices, IndexTensor offsets, IndexTensor offset2bag, IndexTensor bag_size, IndexTensor maximum_indices, int num_weights, bool scale_grad_by_freq, int mode, Tensor? per_sample_weights) -> Tensor + matches_jit_signature: False dispatch: CPU: _embedding_bag_dense_backward_cpu CUDA: _embedding_bag_dense_backward_cuda diff --git a/tools/autograd/derivatives.yaml b/tools/autograd/derivatives.yaml index 50e3226..ae652ad 100644 --- a/tools/autograd/derivatives.yaml +++ b/tools/autograd/derivatives.yaml @@ -958,13 +958,6 @@ weight: _embedding_bag_backward(grad, indices, offsets, result1, result2, result3, weight.size(0), scale_grad_by_freq, mode, sparse, per_sample_weights) per_sample_weights: _embedding_bag_per_sample_weights_backward(grad, weight, indices, result1, mode) -- name: _embedding_bag_dense_backward(Tensor grad, Tensor indices, Tensor offsets, Tensor offset2bag, Tensor bag_size, Tensor maximum_indices, int64_t num_weights, bool scale_grad_by_freq, int64_t mode, Tensor per_sample_weights) - indices: non_differentiable - offsets: non_differentiable - offset2bag: non_differentiable - bag_size: non_differentiable - maximum_indices: non_differentiable - - name: embedding_renorm_(Tensor self, Tensor indices, double max_norm, double norm_type) indices: non_differentiable self: not_implemented("embedding_renorm") -- 2.7.4