From e2f0d509b33e91abf99978af5fe8d45240550c35 Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Tue, 25 Feb 2014 18:28:38 +0100 Subject: [PATCH] Fix dw2-icycle.exp -fsanitize=address GDB crash. binutils readelf -wi: <4>: Abbrev Number: 26 (DW_TAG_inlined_subroutine) DW_AT_abstract_origin: <0x5a> DW_AT_low_pc : 0x400590 DW_AT_high_pc : 0x4 DW_AT_call_file : 1 DW_AT_call_line : 20 DW_AT_sibling : <0xb8> <2>: Abbrev Number: 35 (DW_TAG_inlined_subroutine) DW_AT_abstract_origin: <0x5a> DW_AT_low_pc : 0x400590 DW_AT_high_pc : 0x4 DW_AT_call_file : 1 DW_AT_call_line : 29 DW_AT_sibling points to the next DIE - but that DIE is 2 levels upwards - definitely not a sibling. This confuses GDB up to a crash: ==32143== ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6024000198ac at pc 0xb4d104 bp 0x7fff63e96e70 sp 0x7fff63e96e60 READ of size 1 at 0x6024000198ac thread T0 #0 0xb4d103 in read_unsigned_leb128 (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb4d103) #1 0xb15f3c in peek_die_abbrev (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb15f3c) #2 0xb46185 in load_partial_dies (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb46185) #3 0xb103fb in process_psymtab_comp_unit_reader (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb103fb) #4 0xb0d2a9 in init_cutu_and_read_dies (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb0d2a9) #5 0xb1115f in process_psymtab_comp_unit (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb1115f) #6 0xb1235f in dwarf2_build_psymtabs_hard (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb1235f) #7 0xb05536 in dwarf2_build_psymtabs (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0xb05536) #8 0x86d5a5 in read_psyms (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0x86d5a5) #9 0x9b1c37 in require_partial_symbols (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0x9b1c37) #10 0x9bf2d0 in read_symbols (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0x9bf2d0) #11 0x9c014c in syms_from_objfile_1 (/home/jkratoch/redhat/gdb-clean/gdb/gdb+0x9c014c) gdb/testsuite/ 2014-02-25 Jan Kratochvil Fix dw2-icycle.exp -fsanitize=address GDB crash. * gdb.dwarf2/dw2-icycle.S: Remove all DW_AT_sibling. Message-ID: <20140224201011.GA28926@host2.jankratochvil.net> --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.dwarf2/dw2-icycle.S | 10 ---------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9fa0e96..307aa0f 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-02-25 Jan Kratochvil + + Fix dw2-icycle.exp -fsanitize=address GDB crash. + * gdb.dwarf2/dw2-icycle.S: Remove all DW_AT_sibling. + 2014-02-24 Doug Evans * lib/gdb.exp (run_on_host): Log error output if program fails. diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S index 1f84e4a..938ff20 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-icycle.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-icycle.S @@ -63,21 +63,18 @@ p__top: .uleb128 0x1 /* DW_AT_frame_base */ .byte 0x9c /* DW_OP_call_frame_cfa */ /* DW_AT_GNU_all_call_sites */ - .4byte .S0x4fc - .Ldebug_info0 /* DW_AT_sibling */ .S0x1e0: .uleb128 0x15 /* (DIE (0x1e0) DW_TAG_subprogram) */ .ascii "p__top__middle\0" /* DW_AT_name */ .byte 0x1 /* DW_AT_decl_file (p.adb) */ .byte 0x4 /* DW_AT_decl_line */ .byte 0x1 /* DW_AT_inline */ - .4byte .S0x374 - .Ldebug_info0 /* DW_AT_sibling */ .S0x202: .uleb128 0x15 /* (DIE (0x202) DW_TAG_subprogram) */ .ascii "p__top__middle__inside\0" /* DW_AT_name */ .byte 0x1 /* DW_AT_decl_file (p.adb) */ .byte 0x5 /* DW_AT_decl_line */ .byte 0x1 /* DW_AT_inline */ - .4byte .S0x225 - .Ldebug_info0 /* DW_AT_sibling */ .byte 0 /* end of children of DIE 0x202 */ .S0x225: .uleb128 0x18 /* (DIE (0x225) DW_TAG_subprogram) */ @@ -95,7 +92,6 @@ p__top: .4byte .LBE6-.LFB4 /* DW_AT_high_pc */ .byte 0x1 /* DW_AT_call_file (p.adb) */ .byte 0x14 /* DW_AT_call_line */ - .4byte .S0x374 - .Ldebug_info0 /* DW_AT_sibling */ .byte 0 /* end of children of DIE 0x247 */ .byte 0 /* end of children of DIE 0x225 */ .byte 0 /* end of children of DIE 0x1e0 */ @@ -167,8 +163,6 @@ p__top: .uleb128 0x18 /* (DW_FORM_exprloc) */ .uleb128 0x2117 /* (DW_AT_GNU_all_call_sites) */ .uleb128 0x19 /* (DW_FORM_flag_present) */ - .uleb128 0x1 /* (DW_AT_sibling) */ - .uleb128 0x13 /* (DW_FORM_ref4) */ .byte 0 .byte 0 .uleb128 0x15 /* (abbrev code) */ @@ -182,8 +176,6 @@ p__top: .uleb128 0xb /* (DW_FORM_data1) */ .uleb128 0x20 /* (DW_AT_inline) */ .uleb128 0xb /* (DW_FORM_data1) */ - .uleb128 0x1 /* (DW_AT_sibling) */ - .uleb128 0x13 /* (DW_FORM_ref4) */ .byte 0 .byte 0 .uleb128 0x18 /* (abbrev code) */ @@ -216,8 +208,6 @@ p__top: .uleb128 0xb /* (DW_FORM_data1) */ .uleb128 0x59 /* (DW_AT_call_line) */ .uleb128 0xb /* (DW_FORM_data1) */ - .uleb128 0x1 /* (DW_AT_sibling) */ - .uleb128 0x13 /* (DW_FORM_ref4) */ .byte 0 .byte 0 .uleb128 0x23 /* (abbrev code) */ -- 2.7.4