From e24ed63bd8d172b6b34a0745e647ef46bde30483 Mon Sep 17 00:00:00 2001 From: Sejun Park Date: Wed, 11 Oct 2017 19:04:34 +0900 Subject: [PATCH 1/1] fixed coverity issues Change-Id: I2a8485411a27782ecc1f54920ff5b22e082416bd --- openmax/component/video/dec/h264/Exynos_OMX_H264dec.c | 10 ---------- openmax/component/video/dec/mpeg4/Exynos_OMX_Mpeg4dec.c | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/openmax/component/video/dec/h264/Exynos_OMX_H264dec.c b/openmax/component/video/dec/h264/Exynos_OMX_H264dec.c index bf88e02..c104712 100755 --- a/openmax/component/video/dec/h264/Exynos_OMX_H264dec.c +++ b/openmax/component/video/dec/h264/Exynos_OMX_H264dec.c @@ -592,11 +592,6 @@ OMX_ERRORTYPE H264CodecSrcInit(OMX_COMPONENTTYPE *pOMXComponent) Exynos_OSAL_Log(EXYNOS_LOG_TRACE, "@pVideoDec->pMFCDecInputBuffer[%d]->pVirAddr[%d]: 0x%x", i, plane, pVideoDec->pMFCDecInputBuffer[i]->pVirAddr[plane]); } -#ifdef TIZEN_FEATURE_E3250 - if (pExynosInputPort == NULL || pExynosOutputPort == NULL || pOMXComponent == NULL) { - Exynos_OSAL_Log(EXYNOS_LOG_ERROR, "invalid param: pExynosInputPort= %p pExynosOutputPort= %p pOMXComponent= %p", pExynosInputPort, pExynosOutputPort, pOMXComponent); - } -#endif Exynos_CodecBufferEnQueue(pExynosComponent, INPUT_PORT_INDEX, pVideoDec->pMFCDecInputBuffer[i]); } } else if (pExynosInputPort->bufferProcessType & BUFFER_SHARE) { @@ -1947,11 +1942,6 @@ OMX_ERRORTYPE Exynos_H264Dec_Init(OMX_COMPONENTTYPE *pOMXComponent) Exynos_CodecBufferEnQueue(pExynosComponent, INPUT_PORT_INDEX, pVideoDec->pMFCDecInputBuffer[i]); } } else { -#ifdef TIZEN_FEATURE_E3250 - if (pOMXComponent == NULL) { - Exynos_OSAL_Log(EXYNOS_LOG_ERROR, "%s : %d: invalid parm: pOMXComponent = %p", __FUNCTION__, __LINE__, pOMXComponent); - } -#endif ret = H264CodecSrcInit(pOMXComponent); if (ret != OMX_ErrorNone) goto EXIT; diff --git a/openmax/component/video/dec/mpeg4/Exynos_OMX_Mpeg4dec.c b/openmax/component/video/dec/mpeg4/Exynos_OMX_Mpeg4dec.c index 15bb2e8..e5018bf 100755 --- a/openmax/component/video/dec/mpeg4/Exynos_OMX_Mpeg4dec.c +++ b/openmax/component/video/dec/mpeg4/Exynos_OMX_Mpeg4dec.c @@ -728,11 +728,6 @@ OMX_ERRORTYPE Mpeg4CodecSrcInit(OMX_COMPONENTTYPE *pOMXComponent) Exynos_OSAL_Log(EXYNOS_LOG_TRACE, "@pVideoDec->pMFCDecInputBuffer[%d]->pVirAddr[%d]: 0x%x", i, plane, pVideoDec->pMFCDecInputBuffer[i]->pVirAddr[plane]); } -#ifdef TIZEN_FEATURE_E3250 - if (pExynosInputPort == NULL || pExynosOutputPort == NULL || pOMXComponent == NULL) { - Exynos_OSAL_Log(EXYNOS_LOG_ERROR, "invalid param: pExynosInputPort= %p pExynosOutputPort= %p pOMXComponent= %p", pExynosInputPort, pExynosOutputPort, pOMXComponent); - } -#endif Exynos_CodecBufferEnQueue(pExynosComponent, INPUT_PORT_INDEX, pVideoDec->pMFCDecInputBuffer[i]); } } else if (pExynosInputPort->bufferProcessType & BUFFER_SHARE) { @@ -2048,11 +2043,6 @@ OMX_ERRORTYPE Exynos_Mpeg4Dec_Init(OMX_COMPONENTTYPE *pOMXComponent) Exynos_CodecBufferEnQueue(pExynosComponent, INPUT_PORT_INDEX, pVideoDec->pMFCDecInputBuffer[i]); } } else { -#ifdef TIZEN_FEATURE_E3250 - if (pOMXComponent == NULL) { - Exynos_OSAL_Log(EXYNOS_LOG_ERROR, "%s : %d: invalid parm: pOMXComponent = %p", __FUNCTION__, __LINE__, pOMXComponent); - } -#endif ret = Mpeg4CodecSrcInit(pOMXComponent); if (ret != OMX_ErrorNone) goto EXIT; -- 2.7.4