From e24670b1e2b720ea732517af1767214e41774779 Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Mon, 5 Jun 2017 16:22:08 -0500 Subject: [PATCH] ecore_drm2: Fix error handling in _output_dpms_atomic_set This was skipping the error path on failure and setting some state as if it was successful. Then the next attempt at a page flip was actually setting this state. So _output_dpms_atomic_set (which has always been broken) wasn't actually the function that successfully disabled dpms. This is confounding attempts to debug why dpms isn't coming back on properly. Now it won't turn *off* either, because it really never should have. Ref T5462 --- src/lib/ecore_drm2/ecore_drm2_outputs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/ecore_drm2/ecore_drm2_outputs.c b/src/lib/ecore_drm2/ecore_drm2_outputs.c index 39fb847..263fccd 100644 --- a/src/lib/ecore_drm2/ecore_drm2_outputs.c +++ b/src/lib/ecore_drm2/ecore_drm2_outputs.c @@ -450,6 +450,7 @@ _output_dpms_atomic_set(Ecore_Drm2_Output *output, int level) { ERR("Could not set dpms property: %m"); ret = EINA_FALSE; + goto err; } cstate->dpms.value = level; -- 2.7.4