From e1dcda966edf6acf4fe564975f3922781da52529 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Tue, 8 Mar 2022 10:19:31 -0800 Subject: [PATCH] [libc][NFC] remove completed TODOs There were some "TODO" messages that were for things that I have already completed. This patch removes those. Reviewed By: michaelrj Differential Revision: https://reviews.llvm.org/D121232 --- libc/src/__support/str_to_float.h | 2 -- libc/test/src/__support/str_to_float_test.cpp | 12 ------------ 2 files changed, 14 deletions(-) diff --git a/libc/src/__support/str_to_float.h b/libc/src/__support/str_to_float.h index 8defeed..f7cb2a6 100644 --- a/libc/src/__support/str_to_float.h +++ b/libc/src/__support/str_to_float.h @@ -21,8 +21,6 @@ namespace __llvm_libc { namespace internal { template uint32_t inline leading_zeroes(T inputNumber) { - // TODO(michaelrj): investigate the portability of using something like - // __builtin_clz for specific types. constexpr uint32_t BITS_IN_T = sizeof(T) * 8; if (inputNumber == 0) { return BITS_IN_T; diff --git a/libc/test/src/__support/str_to_float_test.cpp b/libc/test/src/__support/str_to_float_test.cpp index fa2efda..dc70ebc 100644 --- a/libc/test/src/__support/str_to_float_test.cpp +++ b/libc/test/src/__support/str_to_float_test.cpp @@ -259,18 +259,6 @@ TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) { EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA)); EXPECT_EQ(output_exp2, uint32_t(1089)); EXPECT_EQ(errno, 0); - - // TODO(michaelrj): Get long double support working. - - // __uint128_t longDoubleOutputMantissa = 0; - // outputExp2 = 0; - - // errno = 0; - // __llvm_libc::internal::simple_decimal_conversion( - // "123456789012345678900", &longDoubleOutputMantissa, &outputExp2); - // EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA)); - // EXPECT_EQ(outputExp2, uint32_t(1089)); - // EXPECT_EQ(errno, 0); } #if defined(LONG_DOUBLE_IS_DOUBLE) -- 2.7.4