From e1b99971b7a17d1508b84867932538a664536708 Mon Sep 17 00:00:00 2001 From: kargl Date: Sun, 26 Apr 2009 19:27:50 +0000 Subject: [PATCH] 2009-04-26 Steven G. Kargl PR fortran/39893 * gfortran.dg/assumed_charlen_dummy.f90: New Test. 2009-04-26 Steven G. Kargl PR fortran/39893 fortran/data.c (gfc_assign_data_value): If the lvalue is an assumed character length entity in a data statement, then return FAILURE to prevent segmentation fault. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@146816 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/fortran/ChangeLog | 7 +++++++ gcc/fortran/data.c | 6 +++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gfortran.dg/assumed_charlen_dummy.f90 | 10 ++++++++++ 4 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gfortran.dg/assumed_charlen_dummy.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 6c2a442..daafc06 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,10 @@ +2009-04-26 Steven G. Kargl + + PR fortran/39893 + fortran/data.c (gfc_assign_data_value): If the lvalue is an + assumed character length entity in a data statement, then + return FAILURE to prevent segmentation fault. + 2009-04-26 Jakub Jelinek * trans-decl.c: Include pointer-set.h. diff --git a/gcc/fortran/data.c b/gcc/fortran/data.c index 09dde15..5829c7f 100644 --- a/gcc/fortran/data.c +++ b/gcc/fortran/data.c @@ -416,7 +416,11 @@ gfc_assign_data_value (gfc_expr *lvalue, gfc_expr *rvalue, mpz_t index) } if (ref || last_ts->type == BT_CHARACTER) - expr = create_character_intializer (init, last_ts, ref, rvalue); + { + if (lvalue->ts.cl->length == NULL && !(ref && ref->u.ss.length != NULL)) + return FAILURE; + expr = create_character_intializer (init, last_ts, ref, rvalue); + } else { /* Overwriting an existing initializer is non-standard but usually only diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c9f21cf..2c080fa 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2009-04-26 Steven G. Kargl + + PR fortran/39893 + * gfortran.dg/assumed_charlen_dummy.f90: New Test. + 2009-04-26 Jakub Jelinek PR inline-asm/39543 diff --git a/gcc/testsuite/gfortran.dg/assumed_charlen_dummy.f90 b/gcc/testsuite/gfortran.dg/assumed_charlen_dummy.f90 new file mode 100644 index 0000000..04f0b9f --- /dev/null +++ b/gcc/testsuite/gfortran.dg/assumed_charlen_dummy.f90 @@ -0,0 +1,10 @@ +! { dg-do compile } +! Test the fix for PR fortran/39893. +! Original testcase provided by Deji Akingunola. +! Reduced testcase provided by Dominique d'Humieres. +! + SUBROUTINE XAUTOGET() + CHARACTER*(*) DICBA ! { dg-error "Entity with assumed character" } + DATA DICBA /"CLIP" / + RETURN + END -- 2.7.4