From e19dbeab9077c9b01c46a2a048c7de91167ca642 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Fri, 30 Sep 2011 22:00:33 +0000 Subject: [PATCH] [chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed https://bugs.webkit.org/show_bug.cgi?id=69169 Patch by James Robinson on 2011-09-30 Reviewed by Darin Fisher. If the compositor does not process the input event the embedder might want to do something with it - for example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to open a new tab. This passes that state through the didHandleInputEvent callback. * public/WebCompositorClient.h: * src/WebCompositorImpl.cpp: (WebKit::WebCompositorImpl::handleInputEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96430 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebKit/chromium/ChangeLog | 15 +++++++++++++++ Source/WebKit/chromium/public/WebCompositorClient.h | 2 +- Source/WebKit/chromium/src/WebCompositorImpl.cpp | 2 +- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog index 605f833..ad81add 100644 --- a/Source/WebKit/chromium/ChangeLog +++ b/Source/WebKit/chromium/ChangeLog @@ -1,3 +1,18 @@ +2011-09-30 James Robinson + + [chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed + https://bugs.webkit.org/show_bug.cgi?id=69169 + + Reviewed by Darin Fisher. + + If the compositor does not process the input event the embedder might want to do something with it - for + example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to + open a new tab. This passes that state through the didHandleInputEvent callback. + + * public/WebCompositorClient.h: + * src/WebCompositorImpl.cpp: + (WebKit::WebCompositorImpl::handleInputEvent): + 2011-09-30 Elliot Poger webkit->chromium DEPS roll 102910->103471 diff --git a/Source/WebKit/chromium/public/WebCompositorClient.h b/Source/WebKit/chromium/public/WebCompositorClient.h index ed59c12..a6e8048 100644 --- a/Source/WebKit/chromium/public/WebCompositorClient.h +++ b/Source/WebKit/chromium/public/WebCompositorClient.h @@ -32,7 +32,7 @@ class WebCompositorClient { public: // Callbacks invoked from the compositor thread. virtual void willShutdown() = 0; - virtual void didHandleInputEvent() = 0; + virtual void didHandleInputEvent(bool processed) = 0; protected: virtual ~WebCompositorClient() { } diff --git a/Source/WebKit/chromium/src/WebCompositorImpl.cpp b/Source/WebKit/chromium/src/WebCompositorImpl.cpp index ca2967a..b718eb4 100644 --- a/Source/WebKit/chromium/src/WebCompositorImpl.cpp +++ b/Source/WebKit/chromium/src/WebCompositorImpl.cpp @@ -60,7 +60,7 @@ void WebCompositorImpl::setClient(WebCompositorClient* client) void WebCompositorImpl::handleInputEvent(const WebInputEvent& event) { // FIXME: Do something interesting with the event here. - m_client->didHandleInputEvent(); + m_client->didHandleInputEvent(false); } } -- 2.7.4