From e175796fa5a799dfdb71c928fedada5fac315e9c Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Thu, 4 Dec 2014 22:06:30 +0100 Subject: [PATCH] srbchannel: Check return value of pa_memblock_new_pool In case PA_MEMPOOL_DISABLE is set, pa_memblock_new_pool can return NULL. It does not make sense to set up a srbchannel without a shared memory pool, so just fail in this case. Reported-by: Alexander Patrakov Signed-off-by: David Henningsson --- src/pulsecore/srbchannel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pulsecore/srbchannel.c b/src/pulsecore/srbchannel.c index a0f916e76..8872a89f1 100644 --- a/src/pulsecore/srbchannel.c +++ b/src/pulsecore/srbchannel.c @@ -231,6 +231,9 @@ pa_srbchannel* pa_srbchannel_new(pa_mainloop_api *m, pa_mempool *p) { pa_srbchannel* sr = pa_xmalloc0(sizeof(pa_srbchannel)); sr->mainloop = m; sr->memblock = pa_memblock_new_pool(p, -1); + if (!sr->memblock) + goto fail; + srh = pa_memblock_acquire(sr->memblock); pa_zero(*srh); -- 2.34.1