From e10a2585272103b519d09240dbbde84bf89199a4 Mon Sep 17 00:00:00 2001 From: Simon Atanasyan Date: Fri, 24 Apr 2015 11:14:24 +0000 Subject: [PATCH] [Mips] Simplify the code a bit using early return No functional changes. llvm-svn: 235708 --- lld/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/lld/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp b/lld/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp index 7818880..8947d93 100644 --- a/lld/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp +++ b/lld/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp @@ -734,21 +734,13 @@ bool RelocationPass::isDynamic(const Atom *atom) const { const auto *da = dyn_cast(atom); if (da && da->dynamicExport() == DefinedAtom::dynamicExportAlways) return true; - - const auto *sa = dyn_cast(atom); - if (sa) + if (isa(atom)) return true; - - if (_ctx.getOutputELFType() == ET_DYN) { - if (da && da->scope() != DefinedAtom::scopeTranslationUnit) - return true; - - const auto *ua = dyn_cast(atom); - if (ua) - return true; - } - - return false; + if (_ctx.getOutputELFType() != ET_DYN) + return false; + if (da && da->scope() != DefinedAtom::scopeTranslationUnit) + return true; + return isa(atom); } template -- 2.7.4