From e0e7a8ae58fccea3897887381e65ae6307e236e4 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 28 Jun 2018 19:54:27 +0000 Subject: [PATCH] Revert r335907: [OPENMP] Fix incomplete type check for array reductions Sorry, forgot to add commit log attributes again. llvm-svn: 335910 --- clang/lib/Sema/SemaOpenMP.cpp | 2 +- clang/test/OpenMP/parallel_reduction_messages.c | 11 ----------- 2 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 clang/test/OpenMP/parallel_reduction_messages.c diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index 6fb0125..7da9df9 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -10335,7 +10335,7 @@ static bool actOnOMPReductionKindClause( // OpenMP [2.9.3.3, Restrictions, C/C++, p.3] // A variable that appears in a private clause must not have an incomplete // type or a reference type. - if (S.RequireCompleteType(ELoc, D->getType(), + if (S.RequireCompleteType(ELoc, Type, diag::err_omp_reduction_incomplete_type)) continue; // OpenMP [2.14.3.6, reduction clause, Restrictions] diff --git a/clang/test/OpenMP/parallel_reduction_messages.c b/clang/test/OpenMP/parallel_reduction_messages.c deleted file mode 100644 index f88f8e0..0000000 --- a/clang/test/OpenMP/parallel_reduction_messages.c +++ /dev/null @@ -1,11 +0,0 @@ -// RUN: %clang_cc1 -verify -fopenmp -ferror-limit 150 -o - %s - -int incomplete[]; - -void test() { -#pragma omp parallel reduction(+ : incomplete) // expected-error {{a reduction list item with incomplete type 'int []'}} - ; -} - -// complete to suppress an additional warning, but it's too late for pragmas -int incomplete[3]; -- 2.7.4