From e0968ad45948d5b7a89c468576e660381c88148f Mon Sep 17 00:00:00 2001 From: Nathan James Date: Thu, 2 Jul 2020 14:41:03 +0100 Subject: [PATCH] call ::pthread_detach on llvm_execute_on_thread_impl Fixes all TSAN bugs in clangd Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D83039 --- llvm/lib/Support/Unix/Threading.inc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/llvm/lib/Support/Unix/Threading.inc b/llvm/lib/Support/Unix/Threading.inc index 9c1f116..2d0aaca 100644 --- a/llvm/lib/Support/Unix/Threading.inc +++ b/llvm/lib/Support/Unix/Threading.inc @@ -94,6 +94,10 @@ llvm_execute_on_thread_impl(void *(*ThreadFunc)(void *), void *Arg, if ((errnum = ::pthread_join(Thread, nullptr)) != 0) { ReportErrnumFatal("pthread_join failed", errnum); } + } else if (JP == JoiningPolicy::Detach) { + if ((errnum = ::pthread_detach(Thread)) != 0) { + ReportErrnumFatal("pthread_detach failed", errnum); + } } } -- 2.7.4