From e08b849efa7af6cb13d7d3d02dc366b9d7f4208c Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 21 Dec 2018 21:19:09 -0500 Subject: [PATCH] Add debug output for recorded minsyms While discussing this issue: https://sourceware.org/ml/gdb-patches/2018-12/threads.html#00082 I added a printf gated by "set debug symtab-create" to be able to quickly see all minimal symbols recorded by GDB. I thought it would be useful to have it built-in, for the future. Here's how the output looks: Recording minsym: mst_data 0x400780 15 _IO_stdin_used Recording minsym: mst_text 0x400700 13 __libc_csu_init Recording minsym: mst_bss 0x601058 25 _end gdb/ChangeLog: * minsyms.c (mst_str): New. (minimal_symbol_reader::record_full): Add debug output. --- gdb/ChangeLog | 5 +++++ gdb/minsyms.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4fcd2eb..b97500a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-12-21 Simon Marchi + + * minsyms.c (mst_str): New. + (minimal_symbol_reader::record_full): Add debug output. + 2018-12-21 John Baldwin * fbsd-nat.c (fbsd_handle_debug_trap): Require pl.pl_flags to diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 0f85442..e0f3122 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -1080,6 +1080,33 @@ minimal_symbol_reader::record (const char *name, CORE_ADDR address, record_with_info (name, address, ms_type, section); } +/* Convert an enumerator of type minimal_symbol_type to its string + representation. */ + +static const char * +mst_str (minimal_symbol_type t) +{ +#define MST_TO_STR(x) case x: return #x; + switch (t) + { + MST_TO_STR (mst_unknown); + MST_TO_STR (mst_text); + MST_TO_STR (mst_text_gnu_ifunc); + MST_TO_STR (mst_slot_got_plt); + MST_TO_STR (mst_data); + MST_TO_STR (mst_bss); + MST_TO_STR (mst_abs); + MST_TO_STR (mst_solib_trampoline); + MST_TO_STR (mst_file_text); + MST_TO_STR (mst_file_data); + MST_TO_STR (mst_file_bss); + + default: + return "mst_???"; + } +#undef MST_TO_STR +} + /* See minsyms.h. */ struct minimal_symbol * @@ -1112,6 +1139,10 @@ minimal_symbol_reader::record_full (const char *name, int name_len, if (ms_type == mst_file_text && startswith (name, "__gnu_compiled")) return (NULL); + if (symtab_create_debug >= 2) + printf_unfiltered ("Recording minsym: %-21s %18s %4d %s\n", + mst_str (ms_type), hex_string (address), section, name); + if (m_msym_bunch_index == BUNCH_SIZE) { newobj = XCNEW (struct msym_bunch); -- 2.7.4