From e06ac494b8d0f03437dcfdd6cdfba0c68e229c95 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Sun, 10 Oct 2021 01:24:44 +1100 Subject: [PATCH] playbin3: Always register 'playbin3' element. If the USE_PLAYBIN3=1 env var is set, we want to replace playbin with playbin3, but separate to that, we always want to register the 'playbin3' element so that applications which explicitly use playbin3 work regardless of the env var. This fixes `USE_PLAYBIN3=1 gst-validate-launcher`, for example. Part-of: --- subprojects/gst-plugins-base/gst/playback/gstplaybin3.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c index b793664..70a19fe 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c +++ b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c @@ -5196,12 +5196,13 @@ gst_play_bin3_custom_element_init (GstPlugin * plugin) playback_element_init (plugin); - if (g_getenv ("USE_PLAYBIN3")) + if (g_getenv ("USE_PLAYBIN3")) { ret &= gst_element_register (plugin, "playbin", GST_RANK_NONE, GST_TYPE_PLAY_BIN); - else - ret &= gst_element_register (plugin, "playbin3", GST_RANK_NONE, - GST_TYPE_PLAY_BIN); + } + + ret &= gst_element_register (plugin, "playbin3", GST_RANK_NONE, + GST_TYPE_PLAY_BIN); return ret; } -- 2.7.4