From df6d2e8ab1a4212284e4763724a2211df2c7394a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20Storsj=C3=B6?= Date: Fri, 23 Oct 2020 22:51:21 +0300 Subject: [PATCH] [libunwind] Add -Wno-dll-attribute-on-redeclaration when building for windows It's not worth trying to fix these warnings within libunwind, instead silence them. Differential Revision: https://reviews.llvm.org/D90075 --- libunwind/CMakeLists.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libunwind/CMakeLists.txt b/libunwind/CMakeLists.txt index 1c053e6e8b2a..d7e13b78a9c9 100644 --- a/libunwind/CMakeLists.txt +++ b/libunwind/CMakeLists.txt @@ -203,6 +203,14 @@ add_compile_flags_if_supported(-Wundef) add_compile_flags_if_supported(-Wno-suggest-override) +if (WIN32) + # The headers lack matching dllexport attributes (_LIBUNWIND_EXPORT); + # silence the warning instead of cluttering the headers (which aren't + # necessarily the ones that the callers will use anyway) with the + # attributes. + add_compile_flags_if_supported(-Wno-dll-attribute-on-redeclaration) +endif() + if (LIBUNWIND_ENABLE_WERROR) add_compile_flags_if_supported(-Werror) add_compile_flags_if_supported(-WX) -- 2.34.1