From df31c78cf7b9fe7489c1f6df0057b7c220c7cb1c Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Mon, 11 Apr 2011 20:31:29 +0100 Subject: [PATCH] In Perl_op_clear(), uncomment the call to mad_free() Free the MADPROPs when freeing their parent OP, now that all the other bugs are fixed. --- op.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/op.c b/op.c index 4960d22..8523739 100644 --- a/op.c +++ b/op.c @@ -547,18 +547,8 @@ Perl_op_clear(pTHX_ OP *o) PERL_ARGS_ASSERT_OP_CLEAR; #ifdef PERL_MAD - /* if (o->op_madprop && o->op_madprop->mad_next) - abort(); */ - /* FIXME for MAD - if I uncomment these two lines t/op/pack.t fails with - "modification of a read only value" for a reason I can't fathom why. - It's the "" stringification of $_, where $_ was set to '' in a foreach - loop, but it defies simplification into a small test case. - However, commenting them out has caused ext/List/Util/t/weak.t to fail - the last test. */ - /* - mad_free(o->op_madprop); - o->op_madprop = 0; - */ + mad_free(o->op_madprop); + o->op_madprop = 0; #endif retry: -- 2.7.4