From def3d52a159497fa3a0e6ac5a2537bfbf1604b8c Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 4 Jun 2021 17:04:43 -0400 Subject: [PATCH] pan/mdg: Update r1.w comment Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/midgard/midgard_schedule.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/panfrost/midgard/midgard_schedule.c b/src/panfrost/midgard/midgard_schedule.c index 35ba87a..e67b0f4 100644 --- a/src/panfrost/midgard/midgard_schedule.c +++ b/src/panfrost/midgard/midgard_schedule.c @@ -1205,12 +1205,9 @@ mir_schedule_alu( predicate.no_cond = true; } - /* When MRT is in use, writeout loops require r1.w to be filled (with a - * return address? by symmetry with Bifrost, etc), at least for blend - * shaders to work properly. When MRT is not in use (including on SFBD - * GPUs), this is not needed. Blend shaders themselves don't know if - * they are paired with MRT or not so they always need this, at least - * on MFBD GPUs. */ + /* When MRT is in use, writeout loops require r1.w to be filled with a + * return address for the blend shader to jump to. We always emit the + * move for blend shaders themselves for ABI reasons. */ if (writeout && (ctx->inputs->is_blend || ctx->writeout_branch[1])) { vadd = ralloc(ctx, midgard_instruction); -- 2.7.4