From de37f83fbb716d5a1b970c4302ba4c852671d54b Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Thu, 10 Nov 2011 20:58:48 -0700 Subject: [PATCH] podcheck.t: Add comment This is in response to Tony Cook's noticing that the sort order changed, but the data file was left in the old order. The next time someone changed things and did a regen, it got sorted, but the git diff showed more changes, as a result, than there actually were in that commit. --- t/porting/podcheck.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index dbf6fb9..46b6eac 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -1680,7 +1680,9 @@ if (! $has_input_files) { } # If regenerating the data file, start with the modules for which we don't -# check targets +# check targets. If you change the sort order, you need to run --regen before +# committing so that future commits that do run regen don't show irrelevant +# changes. if ($regen) { foreach (sort { lc $a cmp lc $b } keys %valid_modules) { my_safer_print($copy_fh, $_, "\n"); -- 2.7.4