From de2ebd62b9e82c0e349aa152f5e94a8a349b6519 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Fri, 20 Jan 2012 07:18:58 +0000 Subject: [PATCH] Node::canHaveLightChildRendererWithShadow is not used anywhere. https://bugs.webkit.org/show_bug.cgi?id=76627 Patch by Shinya Kawanaka on 2012-01-19 Reviewed by Darin Adler. Since Node::canHaveLightChildRendererWithShadow is not overriden anywhere, and it returns always false. We can remove it. No new tests, because no change in behavior. * dom/Node.h: * dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::shouldCreateRenderer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105484 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 16 ++++++++++++++++ Source/WebCore/dom/Node.h | 1 - Source/WebCore/dom/NodeRenderingContext.cpp | 4 ++-- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index d5816b3..ddad7db 100755 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,19 @@ +2012-01-19 Shinya Kawanaka + + Node::canHaveLightChildRendererWithShadow is not used anywhere. + https://bugs.webkit.org/show_bug.cgi?id=76627 + + Reviewed by Darin Adler. + + Since Node::canHaveLightChildRendererWithShadow is not overriden anywhere, and it returns always false. + We can remove it. + + No new tests, because no change in behavior. + + * dom/Node.h: + * dom/NodeRenderingContext.cpp: + (WebCore::NodeRenderingContext::shouldCreateRenderer): + 2012-01-19 Kinuko Yasuda Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline diff --git a/Source/WebCore/dom/Node.h b/Source/WebCore/dom/Node.h index 09709e0..547dec8 100644 --- a/Source/WebCore/dom/Node.h +++ b/Source/WebCore/dom/Node.h @@ -224,7 +224,6 @@ public: bool isDocumentNode() const; bool isShadowRoot() const { return getFlag(IsShadowRootOrSVGShadowRootFlag) && !isSVGElement(); } virtual bool isContentElement() const { return false; } - virtual bool canHaveLightChildRendererWithShadow() const { return false; } Node* shadowAncestorNode() const; // Returns 0, a ShadowRoot, or a legacy shadow root. diff --git a/Source/WebCore/dom/NodeRenderingContext.cpp b/Source/WebCore/dom/NodeRenderingContext.cpp index 468b8bb..4a9709a 100644 --- a/Source/WebCore/dom/NodeRenderingContext.cpp +++ b/Source/WebCore/dom/NodeRenderingContext.cpp @@ -280,8 +280,8 @@ bool NodeRenderingContext::shouldCreateRenderer() const // See https://bugs.webkit.org/show_bug.cgi?id=52423 if (!parentRenderer->canHaveChildren()) return false; - - if (m_visualParentShadowRoot && !m_parentNodeForRenderingAndStyle->canHaveLightChildRendererWithShadow()) + + if (m_visualParentShadowRoot) return false; } -- 2.7.4